Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-1412: Added Utility Navigation menu configuration. #518

Open
wants to merge 4 commits into
base: 4.x
Choose a base branch
from

Conversation

sethprime
Copy link
Contributor

@sethprime sethprime commented Dec 9, 2024

READY FOR REVIEW

Summary

Adds Utility Navigation menu configuration.

Review By (Date)

Criticality

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Import menu configuration, system.menu.utility-navigation.yml.
  3. Verify Utility Navigation menu present in /admin/structure/menu.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

SDSS-1412: BE | Make Utility Nav Menu

Resources

Copy link
Contributor

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See spelling comment, but otherwise awesome.

Base automatically changed from SDSS-1404-Quickstrike to 4.x December 19, 2024 17:05
@jenbreese
Copy link
Contributor

@buttonwillowsix and @sethprime wait on merging this. I don't see how/why there is a css change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants