Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUL23-662 Created news filtering view display #234

Merged
merged 3 commits into from
Oct 23, 2024
Merged

SUL23-662 Created news filtering view display #234

merged 3 commits into from
Oct 23, 2024

Conversation

pookmish
Copy link
Contributor

NOT READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Oct 23, 2024 0:39am

@rebeccahongsf @pookmish
SUL23-662 | Style news filters (#235)
b13705e 
* SUL23-662 | adjust news filters

* tweak gap

* tweak news card and grid gap

* added empty label option

---------

Co-authored-by: Mike Decker <[email protected]>
@pookmish pookmish changed the title SUL23-662 Stubbed out news filtering view display SUL23-662 Created news filtering view display Oct 23, 2024
@pookmish pookmish merged commit 16fffe0 into 1.x Oct 23, 2024
5 checks passed
@pookmish pookmish deleted the SUL23-662 branch October 23, 2024 00:47
imonroe added a commit that referenced this pull request Nov 5, 2024
@imonroe @pookmish @rebeccahongsf
Release 1.5.0 (#246)
28352b1 
* SUL23 add Related links fields to branch and basic pages

* SUL23-648 | switch twitter bird for X icon (#223)

* SUL23-650 | add Reservation not required to places to study with no reservation button (#224)

* SUL23-650 | add Reservation not required to places to study with no reservation button

* separate conditional for readability

* SUL23-647 | add margin bottom to Dek text (#226)

* SUL23-596: Displays for ascending and descending events (#227)

* SUL23-596: Displays for ascending and descending events

* dependency update

* SUL23-649 | remove underline from checked/selected state (#225)

* SUL23-649 | remove underline from checked/selected state

* remove unused peer-focus:nounderline typo

* added check and hocus underline

---------

Co-authored-by: Mike Decker <[email protected]>

* SUL23-650 | remove margin spacing (#229)

* Redirect branch pages if url is provided

* Updated dependencies

* SUL23-652 | adjust select list to fit content (#228)

* SUL23-638 | Build "on this page" and related content block (#222)

* SUL23-638 | scaffold on the page links component [wip]

* SUL23-638 | configure related links; memo-ize headings; add link styles

* SUL23-638 | resolve type errors

* fixup type err

* add sidebar condition

* revert wysiwyg changes

* rework to use javascript dom query selector

* add on the page block to news and library node types

* account for sidebar navigation

* SUL23-642 | add responsive tablet and mobile select list; tweak layout

* only pass in relLink and relLinkHeading props

* add aria-label

* swap windows.location.href out for next router

* SUL23-645 | configure intersection observer root margin to show active state of a following heading when located at upper 20% of the screen

* tweak styles

* swap out select list for accordion

* remove test selectlist

* update conditional for news and sul branch pages

* add smooth scroll

* add hocus state to desktop anchor links

* check if an id already exists

* remove active state when user is at the top of the page

* add laytout selection id to news

* fixup id of layout selection

* refactor on the page block and rework headings into its own component

* remove active state if first h2 is in the lower section of screen and scroll is at top

* expand to all h2s in main content body

* small tweaks

---------

Co-authored-by: Mike Decker <[email protected]>

* SUL23-655 Refactor tabs to eliminate html validation errors (#230)

* SUL23-650 | update font to match mocks (#231)

* SUL23-649 | switch from peer-focus to peer-focus-visible for toggle underline (#232)

* SUL23-652 | adjust filter width and margin bottom (#233)

* SUL23-652 | adjust filter width and margin bottom

* set min width for all screen sizes

* SUL23-662 Created news filtering view display (#234)

* SUL23-662 Stubbed out news filtering view display

* SUL23-662 | Style news filters (#235)

* SUL23-662 | adjust news filters

* tweak gap

* tweak news card and grid gap

* added empty label option

---------

Co-authored-by: Mike Decker <[email protected]>

---------

Co-authored-by: Rebecca Hong <[email protected]>

* SUL23-638 | update file and heading naming and update intersection observer config (#236)

* SUL23-638 | update file and heading naming

* SUL23-638 | revert intersection observer to previous config

* SUL23-665 | resolve overlapping card image for certain breakpoints (#237)

* SUL23-654 | swap out article for div and add article wrapper to main content (#238)

* SUL23-654 | swap out article for div and add article wrapper to entire main content

* add aria labelledby to article

* SUL23-664 | update to Stanford Libraries for meta data title (#239)

* SUL23-664 | update to Stanford Libraries for meta data title

* switch to hardcoded title

* SUL23-666 | add typography to match places to study (#240)

* Upgrade Next 15, ESLint 9, and React 19 (#241)

* Upgrade Next 15, ESLint 9, and React 19

* fixup modal

* tweaks

* SUL23-668 | change last 12 months to last 90 days (#242)

* SUL23-667 Fix re-render after clearing text input filter

* Pure css to hide/show clear button on text fields (#243)

* Fixed og:title metadata

---------

Co-authored-by: Mike Decker <[email protected]>
Co-authored-by: Rebecca Hong <[email protected]>
Co-authored-by: pookmish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pookmish @rebeccahongsf