-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUL23-665 | resolve overlapping card image for certain breakpoints #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pookmish
approved these changes
Oct 23, 2024
imonroe
added a commit
that referenced
this pull request
Nov 5, 2024
* SUL23 add Related links fields to branch and basic pages * SUL23-648 | switch twitter bird for X icon (#223) * SUL23-650 | add Reservation not required to places to study with no reservation button (#224) * SUL23-650 | add Reservation not required to places to study with no reservation button * separate conditional for readability * SUL23-647 | add margin bottom to Dek text (#226) * SUL23-596: Displays for ascending and descending events (#227) * SUL23-596: Displays for ascending and descending events * dependency update * SUL23-649 | remove underline from checked/selected state (#225) * SUL23-649 | remove underline from checked/selected state * remove unused peer-focus:nounderline typo * added check and hocus underline --------- Co-authored-by: Mike Decker <[email protected]> * SUL23-650 | remove margin spacing (#229) * Redirect branch pages if url is provided * Updated dependencies * SUL23-652 | adjust select list to fit content (#228) * SUL23-638 | Build "on this page" and related content block (#222) * SUL23-638 | scaffold on the page links component [wip] * SUL23-638 | configure related links; memo-ize headings; add link styles * SUL23-638 | resolve type errors * fixup type err * add sidebar condition * revert wysiwyg changes * rework to use javascript dom query selector * add on the page block to news and library node types * account for sidebar navigation * SUL23-642 | add responsive tablet and mobile select list; tweak layout * only pass in relLink and relLinkHeading props * add aria-label * swap windows.location.href out for next router * SUL23-645 | configure intersection observer root margin to show active state of a following heading when located at upper 20% of the screen * tweak styles * swap out select list for accordion * remove test selectlist * update conditional for news and sul branch pages * add smooth scroll * add hocus state to desktop anchor links * check if an id already exists * remove active state when user is at the top of the page * add laytout selection id to news * fixup id of layout selection * refactor on the page block and rework headings into its own component * remove active state if first h2 is in the lower section of screen and scroll is at top * expand to all h2s in main content body * small tweaks --------- Co-authored-by: Mike Decker <[email protected]> * SUL23-655 Refactor tabs to eliminate html validation errors (#230) * SUL23-650 | update font to match mocks (#231) * SUL23-649 | switch from peer-focus to peer-focus-visible for toggle underline (#232) * SUL23-652 | adjust filter width and margin bottom (#233) * SUL23-652 | adjust filter width and margin bottom * set min width for all screen sizes * SUL23-662 Created news filtering view display (#234) * SUL23-662 Stubbed out news filtering view display * SUL23-662 | Style news filters (#235) * SUL23-662 | adjust news filters * tweak gap * tweak news card and grid gap * added empty label option --------- Co-authored-by: Mike Decker <[email protected]> --------- Co-authored-by: Rebecca Hong <[email protected]> * SUL23-638 | update file and heading naming and update intersection observer config (#236) * SUL23-638 | update file and heading naming * SUL23-638 | revert intersection observer to previous config * SUL23-665 | resolve overlapping card image for certain breakpoints (#237) * SUL23-654 | swap out article for div and add article wrapper to main content (#238) * SUL23-654 | swap out article for div and add article wrapper to entire main content * add aria labelledby to article * SUL23-664 | update to Stanford Libraries for meta data title (#239) * SUL23-664 | update to Stanford Libraries for meta data title * switch to hardcoded title * SUL23-666 | add typography to match places to study (#240) * Upgrade Next 15, ESLint 9, and React 19 (#241) * Upgrade Next 15, ESLint 9, and React 19 * fixup modal * tweaks * SUL23-668 | change last 12 months to last 90 days (#242) * SUL23-667 Fix re-render after clearing text input filter * Pure css to hide/show clear button on text fields (#243) * Fixed og:title metadata --------- Co-authored-by: Mike Decker <[email protected]> Co-authored-by: Rebecca Hong <[email protected]> Co-authored-by: pookmish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People