Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nojira | fix media fig caption error #249

Merged
merged 3 commits into from
Dec 4, 2024
Merged

nojira | fix media fig caption error #249

merged 3 commits into from
Dec 4, 2024

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Dec 3, 2024

READY FOR REVIEW

Summary

  • nojira | fix media fig caption error

Review By (Date)

  • Before release

Criticality

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Spin up local
  3. Navigate to /news/les-paroles-politiques-cherubini-celebrates-louis-xviii
  4. Verify that the embed spans full width and the media image captions appear normal
  5. Review code

Associated Issues and/or People

  • SUL23-663

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Dec 4, 2024 0:34am

Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. I'm good with it.

@imonroe imonroe merged commit 48cb3ad into 1.x Dec 4, 2024
4 of 5 checks passed
@imonroe imonroe deleted the bug/nojira-figcaption branch December 4, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants