Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX:SUL23-697 | add green library extended hours notice #250

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Dec 10, 2024

READY FOR REVIEW

Summary

  • HOTFIX:SUL23-697 | add green library extended hours notice

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Navigate to preview site homepage
  2. Verify the extended hours notice appears as outlined in the figma mocks
  3. Verify that the extended hours link redirects to the Green Library extended hours news page (Note: the news page on test differs from the one in production)
  4. Review code 🪴

Associated Issues and/or People

  • SUL23-697

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Dec 10, 2024 1:25am

Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well on the preview site, and seems simple enough. The redirecting URL is hard-coded, but I think that's fine for this purpose. LGTM

@@ -0,0 +1,9 @@
import {SVGProps} from "react"

const MoonStarsIcon = (props: SVGProps<SVGSVGElement>) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I've ever seen the pattern of: take an icon, turn it into an svg, turn the svg into a react component, then use the react component in the layout, but now that I have, I've got to say, I kind of like it. 👍

@imonroe imonroe merged commit 0b738a3 into 1.x Dec 11, 2024
5 checks passed
@imonroe imonroe deleted the feature/SUL23-697--extendedHours branch December 11, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants