Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUL23-691 | add id to branch page h1 to fix arialabelledby html validation error #255

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Jan 7, 2025

READY FOR REVIEW

Summary

  • SUL23-691 | add id to branch page h1 to fix arialabelledby html validation error

Review By (Date)

  • when possible

Review Tasks

Setup tasks and/or behavior to test

  1. Navigate to any branch page (e.g. https://su-library-git-bug-sul23-691-arialabelledby-stanford-libraries.vercel.app/libraries/east-asia-library or https://su-library-git-bug-sul23-691-arialabelledby-stanford-libraries.vercel.app/libraries/archive-recorded-sound)
  2. Copy and paste link into html validator: https://validator.w3.org/
  3. Confirm that the arialabelledby error no longer appears
  4. Review code 🪴

Associated Issues and/or People

  • SUL23-691

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Jan 7, 2025 8:52pm

Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imonroe imonroe merged commit c6b19a4 into 1.x Jan 8, 2025
5 checks passed
@imonroe imonroe deleted the bug/SUL23-691--arialabelledby branch January 8, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants