Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components/atom/popover): lint #2406

Merged
merged 1 commit into from
Oct 18, 2022
Merged

refactor(components/atom/popover): lint #2406

merged 1 commit into from
Oct 18, 2022

Conversation

andresin87
Copy link
Member

@andresin87 andresin87 commented Oct 18, 2022 •
edited
Loading

Atom/Popover

🔍 Show

TASK:

Description, Motivation and Context

Simplify the PopoverExtendChildren file logic

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles

Screenshots - Animations

@andresin87 andresin87 requested a review from kikoruiz as a code owner October 18, 2022 09:48
@andresin87 andresin87 linked an issue Oct 18, 2022 that may be closed by this pull request
✨ AtomPopover replace the TooltipExtendChildren ref code by the useMergeRefs hook #2327
Closed
@andresin87 andresin87 added hacktoberfest-accepted Accepted for hacktoberfest, merged or we will merge later hacktoberfest labels Oct 18, 2022
@andresin87 andresin87 merged commit f921963 into master Oct 18, 2022
@andresin87 andresin87 deleted the 2327-atompopover-replace-the-tooltipextendchildren-ref-code-by-the-usemergerefs-hook branch October 18, 2022 09:50
@github-actions
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0.02↓ ≍ 0.01↑ ≍ 0.07↓ ≍ 0.07↓
% 72.01 57.78 59.51 73.81
ABS 2669 / 3706 1506 / 2606 488 / 820 2574 / 3487

@andresin87 andresin87 linked an issue Oct 18, 2022 that may be closed by this pull request
✨Replace AtomPopover cloneElement by PrimitiveInjector #2328
Closed
@andresin87 andresin87 removed a link to an issue Oct 18, 2022
✨Replace AtomPopover cloneElement by PrimitiveInjector #2328
Closed
@andresin87 andresin87 linked an issue Oct 18, 2022 that may be closed by this pull request
✨Replace AtomPopover cloneElement by PrimitiveInjector #2328
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoruiz kikoruiz Awaiting requested review from kikoruiz kikoruiz is a code owner

@rmoralp rmoralp Awaiting requested review from rmoralp

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@arnau-rius arnau-rius Awaiting requested review from arnau-rius

Assignees

@andresin87 andresin87

Labels
hacktoberfest hacktoberfest-accepted Accepted for hacktoberfest, merged or we will merge later
Projects
None yet
Milestone
No milestone
1 participant
@andresin87