Working version of the morphology pipeline for SOAP output #10

EvgeniiChaikin · 2024-05-02T10:09:39Z

Running morphology pipeline before this update, using VR catalogues: https://swift.dur.ac.uk/COLIBREPlots/chaikin/individual_runs/YEAR2023/z0.0_M_L12N188_new_pipeline/

Running morphology pipeline after this update, using only SOAP output: https://swift.dur.ac.uk/COLIBREPlots/chaikin/individual_runs/YEAR2023/z0.0_M_L12N188_new_pipeline_soap/

TODO

For a given halo, load only a fraction of the particle data from the snapshot, containing only those particles that are close to the halo (currently all snapshot data is loaded)

EvgeniiChaikin · 2024-05-02T11:14:39Z

morpholopy/galaxy_data.py

+        [halo_z - r_size, halo_z + r_size],
+    ]
+
+    swift_mask.constrain_spatial(spatial_mask)


This spatial mask is intended to be used. However, currently I cannot use it because otherwise, I cannot match particle IDs from the snapshot and the soap membership file.

morpholopy/galaxy_data.py

morpholopy/orientation.py

requirements.txt

morpholopy/morphology.py

morpholopy/galaxy_data.py

morpholopy/morphology.py

robjmcgibbon

Other than my comments about unyt, this looks good to me. I was able to run the pipeline and generate the webpage.

EvgeniiChaikin · 2024-05-06T13:35:29Z

Thanks for the comments @robjmcgibbon. I have pushed an update addressing them and unless you have further comments, I am not planning to make any further changes in this PR.

As agreed, the optimization will be handled in another PR.

robjmcgibbon

Looks good to me!

robjmcgibbon

Approval v2

EvgeniiChaikin added 3 commits May 2, 2024 12:06

Make pipeline work for SOAP output instead of VR output

5c0add7

Remove debug prints and add try-except to prevent possible unyt errors

f935c2f

Remove commeted-out, outdated code

9026cf4

EvgeniiChaikin requested a review from robjmcgibbon May 2, 2024 11:12

EvgeniiChaikin assigned robjmcgibbon May 2, 2024