add konst. data #266
Merged
add konst. data #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuSchaller
approved these changes
Nov 8, 2023
| - filename: GalaxyMetallicityDusttoGasRatio/RemyRuyer2014_BPL_COMW.hdf5 | ||
| - filename: GalaxyMetallicityDusttoGasRatio/RemyRuyer2014_Data_COZ.hdf5 | ||
| - filename: GalaxyMetallicityDusttoGasRatio/RemyRuyer2014_BPL_COZ.hdf5 | ||
| - filename: GalaxyMetallicityDusttoGasRatio/Konstantopoulou23_z000p250.hdf5 |
There was a problem hiding this comment.
We should include the data from Konstantopoulou23 as a single file that contains data points at different redshifts, as opposed to different files for different redshifts.
This will ensure that the data is plotted only at a single redshift per plot (the redshift that is closest to the snapshot's redshift) , as opposed to appearing several times in a given plot.
There was a problem hiding this comment.
do you have an example of this being done elsewhere? (In a data conversion script I mean)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plots to show the new Konstantopoulou et al 2023 data on DTM and DTG ratios.
These are based on total metallicities rather than O/H values, so also adding versions of the plot demonstrating representative [O/H] values computed from a solar O/H to see how this might affect things.