[compute] Apply std::string_view #14686
Conversation
This commit applies std::string_view to CLKernelLibraryEx and Einsum. ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
| void set_kernel_path(const std::string &kernel_path) { _kernel_path = kernel_path; }; | ||
| void set_kernel_path(std::string_view kernel_path) { _kernel_path = kernel_path; }; |
There was a problem hiding this comment.
You can use const std::string_view as a parameter. However, since std::string_view is a lightweight, non-owning value type that is typically passed by value, adding const doesn't provide extra safety or performance benefits in most cases. It simply prevents modifications to the local copy of the view inside the function, which is often unnecessary.
| mutable std::map<std::string, const Program> | ||
| mutable std::map<std::string, const Program, std::less<>> |
There was a problem hiding this comment.
https://en.cppreference.com/w/cpp/utility/functional/less_void
A transparent comparator is a comparator type that supports heterogeneous comparisons—that is, it allows you to compare two objects even if they are of different types, as long as they are comparable. In C++ standard library associative containers (like std::map), a comparator is considered transparent if it defines a nested type called is_transparent. For example, std::less<> is a transparent comparator, which lets you compare an std::string with an std::string_view without having to convert one to the other.
| result.push_back(text.substr(start, pos - start)); | ||
| result.push_back(std::string(text.substr(start, pos - start))); |
There was a problem hiding this comment.
Using std::string_view internally can reduce unnecessary copying during the splitting process, which might improve performance in some scenarios. However, since each substring is eventually converted to an std::string for the returned vector, the benefit might be less pronounced if most of the work is spent on that conversion. In many cases, the performance difference compared to the original code will be minor, but for large input strings or in performance-critical contexts, avoiding extra copies could provide some speed improvements.
| void CLKernelLibraryEx::add_built_program(std::string_view built_program_name, cl::Program program) | ||
| void CLKernelLibraryEx::add_built_program(const std::string &built_program_name, | ||
| cl::Program program) |
There was a problem hiding this comment.
Since _built_programs_map is returned via a member function as const std::map<std::string, cl::Program>&, I couldn't use a transparent comparator. Therefore, I reverted the use of std::string_view here.
This commit applies std::string_view to CLKernelLibraryEx and Einsum.
ONE-DCO-1.0-Signed-off-by: ragmani [email protected]