[onert] Simplify code using SFINAE technique #14715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragmani
added
PR/NO MERGE
This commit simplify code using the SFINAE technique. ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
ragmani
force-pushed
the
onert/simplify_sfinae
branch
from
2de16fe to
95600ac
Compare
ragmani
commented
Feb 19, 2025
| typename = std::enable_if_t<std::is_base_of<Operation, OperationType>::value>> | ||
| std::enable_if_t<std::is_base_of_v<Operation, OperationType>, bool> = true> |
There was a problem hiding this comment.
According to cppreference,
A common mistake is to declare two function templates that differ only in their default template arguments. This does not work because the declarations are treated as redeclarations of the same function template (default template arguments are not accounted for in function template equivalence).
it's better to use the explicit dummy parameter version (as in the "RIGHT" example). This ensures that the function signatures are distinct and avoids redefinition errors.
ragmani
commented
Feb 19, 2025
| typename = std::enable_if_t<std::is_base_of<ILoweredGraph, LoweredGraphType>::value>> | ||
| std::enable_if_t<std::is_base_of_v<ILoweredGraph, LoweredGraphType>, bool> = true> |
ragmani
commented
Feb 19, 2025
Comment on lines
-38
to
+39
| template <typename T, typename U> | ||
| typename std::enable_if<std::is_integral<T>::value && std::is_integral<U>::value, | ||
| typename std::common_type<T, U>::type>::type | ||
| ceil_div(T dividend, U divisor) | ||
| template <typename T, typename U, | ||
| std::enable_if_t<std::is_integral_v<T> && std::is_integral_v<U>, bool> = true> |
ragmani
added
PR/ready for review
batcheu
previously approved these changes
Feb 19, 2025
| { | ||
| assert(dividend > 0 && divisor > 0 && "this implementations is for positive numbers only"); | ||
| assert(dividend > 0 && divisor > 0 && "this implementation is for positive numbers only"); |
There was a problem hiding this comment.
(minor)
Is it fine to include a fix that's not related?
There was a problem hiding this comment.
Maybe it's fine to me :) If you would like to separate it, I will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplify code using the SFINAE technique.
ONE-DCO-1.0-Signed-off-by: ragmani [email protected]