Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve CI #281

wants to merge 1 commit into from

Conversation

vorosl
Copy link
Contributor

@vorosl vorosl commented Aug 5, 2024

Test with jit-no-reg-alloc

@vorosl vorosl force-pushed the improve-ci branch 6 times, most recently from f2c7c2b to accf52f Compare August 5, 2024 12:04
@vorosl vorosl marked this pull request as ready for review August 5, 2024 12:19
@clover2123
Copy link
Collaborator

Is there any reason to maintain no-register-allocation mode?
It seems that register allocation is fully applied.

@zherczeg
Copy link
Collaborator

zherczeg commented Aug 6, 2024

It is purely for debugging purposes. It tests memory arguments for operations. We can close the bug (or reduce tests) if it is not necessary. Especially if it increases the CI time.

@@ -89,8 +89,10 @@ jobs:
rm $GITHUB_WORKSPACE/test/wasm-spec/core/call_indirect.wast
$RUNNER --engine="$GITHUB_WORKSPACE/out/clang/x86/walrus"
$RUNNER --jit --engine="$GITHUB_WORKSPACE/out/clang/x64/walrus"
$RUNNER --jit --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit
$RUNNER --no-reg-alloc --engine="$GITHUB_WORKSPACE/out/clang/x64/walrus"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-reg-alloc also enables --jit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment on lines 92 to 95
$RUNNER --jit --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit
$RUNNER --no-reg-alloc --engine="$GITHUB_WORKSPACE/out/clang/x64/walrus"
$RUNNER --engine="$GITHUB_WORKSPACE/out/pure/x64/walrus" basic-tests wasm-test-core jit
$RUNNER --jit --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit
$RUNNER --no-reg-alloc --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of build options increased a lot and seems quite complex.
What about utilizing matrix feature of actions to run each test simply?
(reference of matrix: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs)

@vorosl vorosl force-pushed the improve-ci branch 6 times, most recently from 5527785 to 9822f36 Compare August 6, 2024 12:22
@vorosl vorosl requested review from zherczeg and clover2123 August 6, 2024 12:36
Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one change.

@@ -178,10 +185,18 @@ def main():
parser.add_argument('suite', metavar='SUITE', nargs='*', default=sorted(DEFAULT_RUNNERS),
help='test suite to run (%s; default: %s)' % (', '.join(sorted(RUNNERS.keys())), ' '.join(sorted(DEFAULT_RUNNERS))))
parser.add_argument('--jit', action='store_true', help='test with JIT')
parser.add_argument('--no-reg-alloc', action='store_true', help='test with JIT without register allocation')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--jit-no-reg-alloc

@vorosl vorosl force-pushed the improve-ci branch 8 times, most recently from 76a36c1 to afb179c Compare January 28, 2025 10:37
@vorosl vorosl force-pushed the improve-ci branch 14 times, most recently from 2044eb1 to 6d7e25c Compare February 21, 2025 08:44
@vorosl vorosl mentioned this pull request Feb 21, 2025
@vorosl vorosl force-pushed the improve-ci branch 6 times, most recently from 360dbc0 to b00c051 Compare February 21, 2025 09:12
@vorosl vorosl requested a review from zherczeg February 21, 2025 09:24
@vorosl vorosl force-pushed the improve-ci branch 6 times, most recently from 7795f4e to d0ee9ed Compare February 21, 2025 10:19
RiscV, strategy matrix

Signed-off-by: Laszlo Voros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants