WIP: multi-memory support #331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Feb 12, 2025
src/interpreter/ByteCode.h
Outdated
| @@ -84,6 +84,15 @@ class FunctionType; | |||
| F(Load64) \ | |||
| F(Store32) \ | |||
| F(Store64) \ | |||
| F(MemorySizeMulti) \ | |||
There was a problem hiding this comment.
I think these are rare operations, we could just add multi memory support for them.
src/interpreter/ByteCode.h
Outdated
| F(MemoryInitMulti) \ | ||
| F(MemoryCopyMulti) \ | ||
| F(MemoryFillMulti) \ | ||
| F(Load32Multi) \ |
There was a problem hiding this comment.
Maybe we could use the normal operations when multi memory is used.
matetokodi
force-pushed
the
multi_memory
branch
3 times, most recently
from
c4a7c8c to
599bf56
Compare
Signed-off-by: Máté Tokodi [email protected]
matetokodi
force-pushed
the
multi_memory
branch
from
599bf56 to
f3c27d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, currently all tests pass with the interpreter.