Code fixes based on CodeQL feedback

Signed-off-by: Michał Ryniewicz <[email protected]>
SaptarshiSarkar12 · Jan 22, 2025 · 58ed107 · 58ed107
1 parent 3af9999
commit 58ed107
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/CLI/src/main/java/backend/FileDownloader.java b/CLI/src/main/java/backend/FileDownloader.java
@@ -95,9 +95,7 @@ private void downloadFile() {
                         for (File tempFile : tempFiles) {
                             Files.deleteIfExists(tempFile.toPath());
                         }
-                        for (FileOutputStream fileOutputStream : fileOutputStreams) {
-                            fileOutputStream.close();
-                        }
+                        fileOutputStreams.stream().close();
                     } else {
                         InputStream urlStream = url.openStream();
                         readableByteChannel = Channels.newChannel(urlStream);

diff --git a/Core/src/main/java/utils/DbConnection.java b/Core/src/main/java/utils/DbConnection.java
@@ -35,7 +35,8 @@ public void createTables() throws SQLException {
         String createSessionTableQuery = "CREATE TABLE IF NOT EXISTS SESSION (Id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT, StartDate TEXT NOT NULL, EndDate TEXT);";
         String createFileTableQuery = "CREATE TABLE IF NOT EXISTS FILE (Id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT, FileName TEXT NOT NULL, Url TEXT NOT NULL, SaveTargetPath TEXT NOT NULL, Size INTEGER, DownloadStartTime TEXT, DownloadEndTime TEXT, State INTEGER NOT NULL, SessionId INTEGER NOT NULL, FOREIGN KEY(SessionId) REFERENCES Session(Id));";
         try (PreparedStatement createSessionTableStatement = connection.prepareStatement(createSessionTableQuery);
-                PreparedStatement createFileTableStatement = connection.prepareStatement(createFileTableQuery)) {
+             PreparedStatement createFileTableStatement = connection.prepareStatement(createFileTableQuery))
+        {
             createSessionTableStatement.executeUpdate();
             createFileTableStatement.executeUpdate();
         }