avformat/httpauth: do not decode plus sign to space in credentials

Signed-off-by: Marton Balint <[email protected]>
SaschaVasarrhelyi · Feb 15, 2020 · 3004ef1 · 3004ef1
1 parent 8224f1e
commit 3004ef1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c
@@ -255,7 +255,7 @@ char *ff_http_auth_create_response(HTTPAuthState *state, const char *auth,
 
     if (state->auth_type == HTTP_AUTH_BASIC) {
         int auth_b64_len, len;
-        char *ptr, *decoded_auth = ff_urldecode(auth, 1);
+        char *ptr, *decoded_auth = ff_urldecode(auth, 0);
 
         if (!decoded_auth)
             return NULL;
@@ -275,7 +275,7 @@ char *ff_http_auth_create_response(HTTPAuthState *state, const char *auth,
         av_strlcat(ptr, "\r\n", len - (ptr - authstr));
         av_free(decoded_auth);
     } else if (state->auth_type == HTTP_AUTH_DIGEST) {
-        char *username = ff_urldecode(auth, 1), *password;
+        char *username = ff_urldecode(auth, 0), *password;
 
         if (!username)
             return NULL;