Skip to content

Commit

Permalink
lavc/videotoolboxenc: explicitly set realtime=false
Browse files Browse the repository at this point in the history
On some encoders, this defaults to true, which can result in encode speed
being _limited_ to only slightly above realtime (as a power-saving measure),
so we need a way to disable it.
  • Loading branch information
rcombs committed Dec 23, 2021
1 parent 802c051 commit 4778ab2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions libavcodec/videotoolboxenc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1389,10 +1389,10 @@ static int vtenc_create_encoder(AVCodecContext *avctx,
}
}

if (vtctx->realtime) {
if (vtctx->realtime >= 0) {
status = VTSessionSetProperty(vtctx->session,
compat_keys.kVTCompressionPropertyKey_RealTime,
kCFBooleanTrue);
vtctx->realtime ? kCFBooleanTrue : kCFBooleanFalse);

if (status) {
av_log(avctx, AV_LOG_ERROR, "Error setting realtime property: %d\n", status);
Expand Down Expand Up @@ -2677,7 +2677,7 @@ static const enum AVPixelFormat prores_pix_fmts[] = {
{ "require_sw", "Require software encoding", OFFSET(require_sw), AV_OPT_TYPE_BOOL, \
{ .i64 = 0 }, 0, 1, VE }, \
{ "realtime", "Hint that encoding should happen in real-time if not faster (e.g. capturing from camera).", \
OFFSET(realtime), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, \
OFFSET(realtime), AV_OPT_TYPE_BOOL, { .i64 = 0 }, -1, 1, VE }, \
{ "frames_before", "Other frames will come before the frames in this session. This helps smooth concatenation issues.", \
OFFSET(frames_before), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, \
{ "frames_after", "Other frames will come after the frames in this session. This helps smooth concatenation issues.", \
Expand Down

0 comments on commit 4778ab2

Please sign in to comment.