Skip to content

Commit

Permalink
rtpdec: Pass the sequence number to depacketizers
Browse files Browse the repository at this point in the history
This allows depacketizers to figure out if packets have been lost.

Signed-off-by: Martin Storsjö <[email protected]>
  • Loading branch information
mstorsjo committed Dec 21, 2012
1 parent 0a0e340 commit 90c784c
Show file tree
Hide file tree
Showing 18 changed files with 43 additions and 40 deletions.
6 changes: 3 additions & 3 deletions libavformat/rdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ ff_rdt_parse_header(const uint8_t *buf, int len,
static int
rdt_parse_packet (AVFormatContext *ctx, PayloadContext *rdt, AVStream *st,
AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t rtp_seq, int flags)
{
int seq = 1, res;
AVIOContext pb;
Expand Down Expand Up @@ -348,7 +348,7 @@ ff_rdt_parse_packet(RDTDemuxContext *s, AVPacket *pkt,
timestamp= 0; ///< Should not be used if buf is NULL, but should be set to the timestamp of the packet returned....
rv= s->parse_packet(s->ic, s->dynamic_protocol_context,
s->streams[s->prev_stream_id],
pkt, &timestamp, NULL, 0, flags);
pkt, &timestamp, NULL, 0, 0, flags);
return rv;
}

Expand All @@ -375,7 +375,7 @@ ff_rdt_parse_packet(RDTDemuxContext *s, AVPacket *pkt,

rv = s->parse_packet(s->ic, s->dynamic_protocol_context,
s->streams[s->prev_stream_id],
pkt, &timestamp, buf, len, flags);
pkt, &timestamp, buf, len, 0, flags);

return rv;
}
Expand Down
5 changes: 3 additions & 2 deletions libavformat/rtpdec.c
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ static int rtp_parse_packet_internal(RTPDemuxContext *s, AVPacket *pkt,
return 0;
} else if (s->parse_packet) {
rv = s->parse_packet(s->ic, s->dynamic_protocol_context,
s->st, pkt, &timestamp, buf, len, flags);
s->st, pkt, &timestamp, buf, len, seq, flags);
} else {
/* At this point, the RTP header has been stripped;
* This is ASSUMING that there is only 1 CSRC, which isn't wise. */
Expand Down Expand Up @@ -682,7 +682,8 @@ static int rtp_parse_one_packet(RTPDemuxContext *s, AVPacket *pkt,
* the packet is left with pts == AV_NOPTS_VALUE */
timestamp = RTP_NOTS_VALUE;
rv = s->parse_packet(s->ic, s->dynamic_protocol_context,
s->st, pkt, &timestamp, NULL, 0, flags);
s->st, pkt, &timestamp, NULL, 0, 0,
flags);
finalize_packet(s, pkt, timestamp);
return rv;
} else {
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,15 @@ typedef struct RTPStatistics {
* updated by the function if returning older, buffered data
* @param buf pointer to raw RTP packet data
* @param len length of buf
* @param seq RTP sequence number of the packet
* @param flags flags from the RTP packet header (RTP_FLAG_*)
*/
typedef int (*DynamicPayloadPacketHandlerProc)(AVFormatContext *ctx,
PayloadContext *s,
AVStream *st, AVPacket *pkt,
uint32_t *timestamp,
const uint8_t * buf,
int len, int flags);
int len, uint16_t seq, int flags);

struct RTPDynamicProtocolHandler {
const char enc_name[50];
Expand Down
11 changes: 4 additions & 7 deletions libavformat/rtpdec_amr.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,10 @@ static void amr_free_context(PayloadContext *data)
av_free(data);
}

static int amr_handle_packet(AVFormatContext *ctx,
PayloadContext *data,
AVStream *st,
AVPacket * pkt,
uint32_t * timestamp,
const uint8_t * buf,
int len, int flags)
static int amr_handle_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
const uint8_t *frame_sizes = NULL;
int frames;
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_asf.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ struct PayloadContext {
static int asfrtp_parse_packet(AVFormatContext *s, PayloadContext *asf,
AVStream *st, AVPacket *pkt,
uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
AVIOContext *pb = &asf->pb;
int res, mflags, len_off;
Expand Down
2 changes: 1 addition & 1 deletion libavformat/rtpdec_formats.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ int ff_wms_parse_sdp_a_line(AVFormatContext *s, const char *p);

int ff_h263_handle_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags);
const uint8_t *buf, int len, uint16_t seq, int flags);

extern RTPDynamicProtocolHandler ff_amr_nb_dynamic_handler;
extern RTPDynamicProtocolHandler ff_amr_wb_dynamic_handler;
Expand Down
2 changes: 1 addition & 1 deletion libavformat/rtpdec_h263.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

int ff_h263_handle_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq, int flags)
{
uint8_t *ptr;
uint16_t header;
Expand Down
7 changes: 4 additions & 3 deletions libavformat/rtpdec_h263_rfc2190.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,16 @@ static void h263_free_context(PayloadContext *data)

static int h263_handle_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
/* Corresponding to header fields in the RFC */
int f, p, i, sbit, ebit, src, r;
int header_size, ret;

if (data->newformat)
return ff_h263_handle_packet(ctx, data, st, pkt, timestamp, buf, len,
flags);
seq, flags);

if (data->buf && data->timestamp != *timestamp) {
/* Dropping old buffered, unfinished data */
Expand Down Expand Up @@ -122,7 +123,7 @@ static int h263_handle_packet(AVFormatContext *ctx, PayloadContext *data,
"signalled with a static payload type.\n");
data->newformat = 1;
return ff_h263_handle_packet(ctx, data, st, pkt, timestamp, buf,
len, flags);
len, seq, flags);
}
}

Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_h264.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ static int sdp_parse_fmtp_config_h264(AVStream *stream,
// return 0 on packet, no more left, 1 on packet, 1 on partial packet
static int h264_handle_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
uint8_t nal;
uint8_t type;
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_jpeg.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ static void create_default_qtables(uint8_t *qtables, uint8_t q)

static int jpeg_parse_packet(AVFormatContext *ctx, PayloadContext *jpeg,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
uint8_t type, q, width, height;
const uint8_t *qtables = NULL;
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_latm.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ static void latm_free_context(PayloadContext *data)

static int latm_parse_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
int ret, cur_len;

Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_mpeg4.c
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ static int rtp_parse_mp4_au(PayloadContext *data, const uint8_t *buf)
/* Follows RFC 3640 */
static int aac_parse_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
if (rtp_parse_mp4_au(data, buf))
return -1;
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_qcelp.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ static int return_stored_frame(AVFormatContext *ctx, PayloadContext *data,

static int qcelp_parse_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
if (buf)
return store_packet(ctx, data, st, pkt, timestamp, buf, len);
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_qdm2.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ static int qdm2_restore_block(PayloadContext *qdm, AVStream *st, AVPacket *pkt)
static int qdm2_parse_packet(AVFormatContext *s, PayloadContext *qdm,
AVStream *st, AVPacket *pkt,
uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
int res = AVERROR_INVALIDDATA, n;
const uint8_t *end = buf + len, *p = buf;
Expand Down
2 changes: 1 addition & 1 deletion libavformat/rtpdec_qt.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ struct PayloadContext {
static int qt_rtp_parse_packet(AVFormatContext *s, PayloadContext *qt,
AVStream *st, AVPacket *pkt,
uint32_t *timestamp, const uint8_t *buf,
int len, int flags)
int len, uint16_t seq, int flags)
{
AVIOContext pb;
GetBitContext gb;
Expand Down
3 changes: 2 additions & 1 deletion libavformat/rtpdec_svq3.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ struct PayloadContext {
static int svq3_parse_packet (AVFormatContext *s, PayloadContext *sv,
AVStream *st, AVPacket *pkt,
uint32_t *timestamp,
const uint8_t *buf, int len, int flags)
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
int config_packet, start_packet, end_packet;

Expand Down
11 changes: 4 additions & 7 deletions libavformat/rtpdec_vp8.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,10 @@ struct PayloadContext {
uint32_t timestamp;
};

static int vp8_handle_packet(AVFormatContext *ctx,
PayloadContext *vp8,
AVStream *st,
AVPacket *pkt,
uint32_t *timestamp,
const uint8_t *buf,
int len, int flags)
static int vp8_handle_packet(AVFormatContext *ctx, PayloadContext *vp8,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, uint16_t seq,
int flags)
{
int start_partition, end_packet;
int extended_bits, part_id;
Expand Down
10 changes: 4 additions & 6 deletions libavformat/rtpdec_xiph.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,10 @@ static void xiph_free_context(PayloadContext * data)
av_free(data);
}

static int xiph_handle_packet(AVFormatContext * ctx,
PayloadContext * data,
AVStream * st,
AVPacket * pkt,
uint32_t * timestamp,
const uint8_t * buf, int len, int flags)
static int xiph_handle_packet(AVFormatContext *ctx, PayloadContext *data,
AVStream *st, AVPacket *pkt, uint32_t *timestamp,
const uint8_t *buf, int len, uint16_t seq,
int flags)
{

int ident, fragmented, tdt, num_pkts, pkt_len;
Expand Down

0 comments on commit 90c784c

Please sign in to comment.