Skip to content

Commit

Permalink
avfilter/drawbox: rename variable for maximum thickness
Browse files Browse the repository at this point in the history
The present value name for maximum thickness is 'max' which results in a
parse error of any thickness expression containing 'max(val1,val2)'.

Value renamed to 'fill'. Tested locally and documented.

Signed-off-by: Michael Niedermayer <[email protected]>
  • Loading branch information
GyanD authored and michaelni committed Nov 28, 2017
1 parent 002db7d commit b3cb9bd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions doc/filters.texi
Original file line number Diff line number Diff line change
Expand Up @@ -7142,7 +7142,8 @@ value @code{invert} is used, the box edge color is the same as the
video with inverted luma.

@item thickness, t
The expression which sets the thickness of the box edge. Default value is @code{3}.
The expression which sets the thickness of the box edge.
A value of @code{fill} will create a filled box. Default value is @code{3}.

See below for the list of accepted constants.
@end table
Expand Down Expand Up @@ -7205,7 +7206,7 @@ drawbox=x=10:y=20:w=200:h=60:color=red@@0.5
@item
Fill the box with pink color:
@example
drawbox=x=10:y=10:w=100:h=100:color=pink@@0.5:t=max
drawbox=x=10:y=10:w=100:h=100:color=pink@@0.5:t=fill
@end example

@item
Expand Down
2 changes: 1 addition & 1 deletion libavfilter/vf_drawbox.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static const char *const var_names[] = {
"h", ///< height of the rendered box
"w", ///< width of the rendered box
"t",
"max",
"fill",
NULL
};

Expand Down

0 comments on commit b3cb9bd

Please sign in to comment.