mpegvideoenc: Fail if a buffer size is specified without a max rate.

This combination makes not much sense. Signed-off-by: Michael Niedermayer <[email protected]>
SaschaVasarrhelyi · Jan 28, 2012 · f21b615 · f21b615
1 parent 49f2056
commit f21b615
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
@@ -392,10 +392,8 @@ av_cold int MPV_encode_init(AVCodecContext *avctx)
     s->obmc             = !!(s->flags  & CODEC_FLAG_OBMC);
 #endif
 
-    if (avctx->rc_max_rate && !avctx->rc_buffer_size) {
-        av_log(avctx, AV_LOG_ERROR,
-               "a vbv buffer size is needed, "
-               "for encoding with a maximum bitrate\n");
+    if ((!avctx->rc_max_rate) != (!avctx->rc_buffer_size)) {
+        av_log(avctx, AV_LOG_ERROR, "Either both buffer size and max rate or neither must be specified\n");
         return -1;
     }