Talon swerve changes #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re --> check vision before approving
Yxhej
requested changes
Jan 14, 2025
Yxhej
requested changes
Jan 16, 2025
|
|
||
| for (int j = 0; j < unread.size(); j++) { | ||
| var change = unread.get(j); | ||
| changes[i][j] = unread.get(j); |
There was a problem hiding this comment.
On second thought, this doesn't really work because we can't know the size of the unread results. This means that past changes might not be overriden, and we'll be displaying old data, which definitely isn't good.
Yeah... let's just use an ArrayList.
There was a problem hiding this comment.
............so what i suggested initially.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now utilize Talons when case Talon is selected while building Drive. Tell me if there are any wonky things going on.
Additionally, vision changes may have accidentally been stashed and applied to this PR too. Please clear vision first or do as you please.