Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyfix eccodes 2v38 #578

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Nov 29, 2024

This also fixes a numpy2 problem.

Once working, should unblock the lockfile update (see #550).

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (180c24e) to head (1719b7e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files           8        8           
  Lines        2473     2473           
  Branches      420      420           
=======================================
  Hits         2216     2216           
  Misses        159      159           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers trexfeathers merged commit f835fc9 into SciTools:main Dec 2, 2024
10 checks passed
@pp-mo
Copy link
Member Author

pp-mo commented Dec 2, 2024

Whoops I should have made this a Draft.

Unpinning numpy 2 reveals that the "other" problem isn't really fixed
as it breaks at least the unit-test in src/iris_grib/tests/unit/load_convert/test__hindcast_fix.py::TestHindcastFix

I am working on this, will sort it out + unblock the lockfile upate.
I'm thinking it may then be good to issue a "bugfix release" -- or similar, given that we don't have a major release yet (!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants