Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dataless cubes #6253
base: main
Are you sure you want to change the base?
Implement dataless cubes #6253
Changes from all commits
96a3f2d
a2e0da9
7114f0f
84ea908
44afb25
cdc51d5
7b402e0
bc1ee6f
17e0b30
16779aa
f42c19d
b4ffc31
6d62c7d
cc13e6d
71c7ae8
e59d5c9
95c09e1
b2fb2f8
c6510a5
af7d727
144e164
ba84553
ea3c150
0cec4ca
6ed270d
d79ad27
2bb6e61
063e45b
79d7d67
9b52067
2f2b56a
c8d2c07
67fb787
379b273
a042451
088bb94
21489d5
a059c5e
19e956d
8178809
2123b8f
703bbb6
33649c1
021bd31
f1bfe7b
abb5a57
94d02ea
5be6a1f
5c5bbf8
de348f9
7c74460
0ceed69
8bddec7
2a67050
f8c2dad
ed75485
9221917
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be clearer as
if is_lazy == is_real
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ESadek-MO Require to update the
data
getter doc-string to state thatNone
will be returned in the dataless case.As it happens, you're getting that behaviour for free i.e., when we're dataless then
self._real_array
will beNone
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ESadek-MO Don't we require to set
self._real_array = None
andself._lazy_array = None
then check the axiom only in thedataless
case?i.e., do that and nothing further.