Use a generated SVG logo #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
commented
Nov 25, 2024
Comment on lines
-137
to
-138
| # docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32 | ||
| # pixels large. |
There was a problem hiding this comment.
This hasn't been true for years for most web browsers. The Iris Readthedocs page uses an SVG and that works just fine.
|
Gonna try to get it back down to the original size. |
OK regardless of pixel size it seems to still render pretty big in RTD. There is probably some config we can put in
|
|
I like the concept, feel like the code could be fiddled with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Use a generated SVG logo instead of the current one. Please tweak this however you like to get the logo you really want. And note that until this afternoon I had never used Tephi so if I've done something heinous please call me out on it!
Description