Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GovernorCountingFractional (Bump OZ to v5.1) #79

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

davidlaprade
Copy link
Contributor

@davidlaprade davidlaprade commented Jan 9, 2025

This should NOT be merged until we cut a v2.0 for the version of the repo on OZ v5.0 (prior to their inclusion of GovCountingFractional).

I also bumped foundry

@davidlaprade davidlaprade changed the title Bump OZ to v5.1 Remove GovernorCountingFractional (Bump OZ to v5.1) Jan 9, 2025
@davidlaprade davidlaprade marked this pull request as ready for review January 9, 2025 21:39
Copy link

Coverage after merging bump-oz-to-v5.1 into master will be

89.17%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   FlexVotingClient.sol100%100%100%100%
   FractionalPool.sol79.44%70.59%73.33%82.67%110, 112, 114, 117, 192–193, 195–197, 200, 204, 240–241, 81, 83, 85–86, 88

@davidlaprade davidlaprade merged commit d3c62a3 into master Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants