Fix PnP progress step comparison with project date range (#3337)

Co-authored-by: Carson Full <[email protected]>
SeedCompany · Dec 12, 2024 · 32e2922 · 32e2922
1 parent 993aa9d
commit 32e2922
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/components/pnp/isProgressCompletedOutsideProject.ts b/src/components/pnp/isProgressCompletedOutsideProject.ts
@@ -15,7 +15,10 @@ export const isProgressCompletedOutsideProject = (
   if (!completeDate) {
     return false;
   }
-  if (pnp.planning.projectDateRange.contains(completeDate)) {
+  // Steps completion dates smallest unit is quarters, so expand project range to that.
+  const projectTimeframe =
+    pnp.planning.projectDateRange.expandToFull('quarter');
+  if (projectTimeframe.contains(completeDate)) {
     return false;
   }
 
@@ -25,7 +28,7 @@ export const isProgressCompletedOutsideProject = (
     completeDate,
   )}`;
 
-  if (pnp.planning.projectDateRange.isAfter(completeDate)) {
+  if (projectTimeframe.isAfter(completeDate)) {
     result.addProblem({
       severity: 'Notice',
       groups: [