-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EdgeDB] Create Product.CompletionDescription
schema
#3089
base: develop
Are you sure you want to change the base?
Conversation
Product.CompletionDescription
schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarsonF - I'm unsure how/if the possible matches provided by the query search play in here?
Yeah this uses full text search. We'll need FTS indexes here eventually. Something like this cord-api-v3/dbschema/z.named.esdl Lines 9 to 14 in 63a27a2
The EdgeQL query will be something like select fts::search(Product::CompletionDescription, '<query>', language := 'eng'); |
49a6688
to
0f357ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still wonder if we actually need this object or product holds enough info to use.
Still need the FTS index either way. We can revisit with the queries.
Monday
┆Issue is synchronized with this Monday item by Unito
https://seed-company-squad.monday.com/boards/5989610236/pulses/5799854716