Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeDB] Add FinancialReport and NarrativeReport seeding #3240

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bryanjnelson
Copy link
Contributor

@bryanjnelson bryanjnelson commented Jun 14, 2024

Monday story

Monday task

Description

Add seeding for FinancialReports and NarrativeReports.

Ready for review checklist

Use [N/A] if the item is not applicable to this PR or remove the item

  • Change the task url above to the actual Monday task
  • Add reviewers to this PR

@bryanjnelson bryanjnelson requested a review from CarsonF as a code owner June 14, 2024 17:24
@bryanjnelson
Copy link
Contributor Author

@CarsonF - The open question here is if we would also like to include seeding for ProgressReports in this same file. Since it is considerably different, I lean toward making that an entirely different seeding file. Thoughts?

Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I don't really like the denormalized dates, since these are based on the project date range.

@CarsonF
Copy link
Member

CarsonF commented Aug 8, 2024

Oh can we pick a project to be monthly financial reporting and add those here.

@bryanjnelson
Copy link
Contributor Author

Oh can we pick a project to be monthly financial reporting and add those here.

    {
      "type": "Financial",
      "project": "Glorfindel - Exegetical Facilitator",
      "start": "2025-01-01",
      "end": "2025-03-31",
      "receivedDate": "2025-04-01"
    },

That one is in there and the project looks like this already:

  {
    name: 'Glorfindel - Exegetical Facilitator',
    step: 'DiscussingChangeToPlan',
    mouStart: '2021-07-01',
    mouEnd: '2024-12-30',
    primaryLocation: 'Sweden',
    estimatedSubmission: '2024-10-01',
    financialReportPeriod: 'Monthly',
  },

Is that what you were going after?

@CarsonF
Copy link
Member

CarsonF commented Aug 8, 2024

Is that what you were going after?

Oh yeah. So that start/end date is wrong. The reports should be monthly not quarterly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants