Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engagement date filters #3276

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Engagement date filters #3276

merged 3 commits into from
Aug 7, 2024

Conversation

brentkulwicki
Copy link
Contributor

@brentkulwicki brentkulwicki commented Aug 7, 2024

Monday task

Ready for review checklist

Use [N/A] if the item is not applicable to this PR or remove the item

  • Change the task url above to the actual Monday task
  • Add/update tests if needed
  • Add reviewers to this PR

Copy link

github-actions bot commented Aug 7, 2024

🗞 GraphQL Summary

View schema changes
@@ -1473,8 +1473,10 @@
   statusModifiedAt: SecuredDateTime!
 }
 
 input EngagementFilters {
+  endDate: DateFilter
+
   """Only engagements whose engaged entity (language / user) name match"""
   engagedName: String
   intern: UserFilters
   language: LanguageFilters
@@ -1483,8 +1485,9 @@
   Only engagements whose project or engaged entity (language / user) name match
   """
   name: String
   project: ProjectFilters
+  startDate: DateFilter
   status: [EngagementStatus!]
 
   """Only engagements matching this type"""
   type: String

⚠️ Dangerous Changes

  • An optional field endDate on input type EngagementFilters was added.
  • An optional field startDate on input type EngagementFilters was added.

@CarsonF CarsonF force-pushed the engagement-date-filters branch from 35bba00 to 88a9b52 Compare August 7, 2024 18:26
@CarsonF CarsonF changed the title start to engagement date filters Engagement date filters Aug 7, 2024
@CarsonF CarsonF marked this pull request as ready for review August 7, 2024 18:30
@CarsonF CarsonF self-requested a review as a code owner August 7, 2024 18:30
@CarsonF CarsonF enabled auto-merge August 7, 2024 18:30
@CarsonF CarsonF merged commit 249d157 into develop Aug 7, 2024
15 checks passed
@CarsonF CarsonF deleted the engagement-date-filters branch August 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants