[EdgeDB] - Add trigger to appropriately create financial/narrative report upon project creation #3279
+194
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,7 +120,7 @@ module default { | |
| } | ||
| ); | ||
|
|
||
| trigger createPeriodicReports after insert for each do ( | ||
| with | ||
| interval := (select | ||
| if __new__.financialReportPeriod = default::ReportPeriod.Monthly then '1' else '3'), | ||
|
|
@@ -140,7 +140,6 @@ module default { | |
| projectContext := __new__.projectContext, | ||
| container := __new__, | ||
| period := reportRange | ||
| }), | ||
| (insert default::NarrativeReport { | ||
| createdAt := datetime_of_statement(), | ||
|
|
@@ -153,7 +152,107 @@ module default { | |
| period := reportRange | ||
| }) | ||
| ) | ||
| ); | ||
|
|
||
| trigger addRemovePeriodicReports after update for each | ||
| when ( | ||
| __old__.mouStart != __new__.mouStart | ||
| or __old__.mouEnd != __new__.mouEnd | ||
| or __old__.financialReportPeriod != __new__.financialReportPeriod | ||
| ) | ||
| do ( | ||
| with | ||
| existingReportPeriods := ( | ||
| select FinancialReport | ||
| filter .container.id = __old__.id | ||
| ).period, | ||
| interval := ( | ||
| select (if __new__.financialReportPeriod = default::ReportPeriod.Monthly then '1' else '3') | ||
| ), | ||
| requestedReportPeriods := Project::create_periodic_report_ranges( | ||
| __new__.mouStart, | ||
| __new__.mouEnd, | ||
| interval | ||
| ) | ||
| if __old__.financialReportPeriod != __new__.financialReportPeriod ( | ||
CarsonF marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| with | ||
| reportPeriodsWithoutFiles := ( | ||
| select existingReportPeriods | ||
| filter not exists .reportFile | ||
| ), | ||
| deletedReportPeriods : = ( | ||
| for reportPeriod in reportPeriodsWithoutFiles | ||
| union ( | ||
| delete reportPeriod | ||
| ) | ||
| ) | ||
| for reportPeriod in requestedReportPeriods | ||
| union ( | ||
| (insert default::FinancialReport { | ||
| createdAt := datetime_of_statement(), | ||
| modifiedAt := datetime_of_statement(), | ||
| createdBy := assert_exists(global currentActor), | ||
| modifiedBy := assert_exists(global currentActor), | ||
| project := __new__, | ||
| projectContext := __new__.projectContext, | ||
| container := __new__, | ||
| period := reportPeriod | ||
| }), | ||
| (insert default::NarrativeReport { | ||
| createdAt := datetime_of_statement(), | ||
| modifiedAt := datetime_of_statement(), | ||
| createdBy := assert_exists(global currentActor), | ||
| modifiedBy := assert_exists(global currentActor), | ||
| project := __new__, | ||
| projectContext := __new__.projectContext, | ||
| container := __new__, | ||
| period := reportPeriod | ||
| }) | ||
| ) | ||
| ) else ( | ||
| with | ||
| requestedReportPeriodsForInsertion := ( | ||
| select requestedReportPeriods | ||
| filter requestedReportPeriods not in existingReportPeriods | ||
| ), | ||
| requestedReportPeriodsForDeletion := ( | ||
| select existingReportPeriods | ||
| filter existingReportPeriods not in requestedReportPeriods | ||
| ), | ||
| applicableReportPeriodsForDeletion := ( | ||
| select PeriodicReport[is FinancialReport | NarrativeReport] | ||
| filter .period in requestedReportPeriodsForDeletion | ||
| and not exists .reportFile | ||
| ), | ||
| insertedReportPeriods := (for reportPeriod in requestedReportPeriodsForInsertion | ||
| union ( | ||
| (insert default::FinancialReport { | ||
| createdAt := datetime_of_statement(), | ||
| modifiedAt := datetime_of_statement(), | ||
| createdBy := assert_exists(global currentActor), | ||
| modifiedBy := assert_exists(global currentActor), | ||
| project := __new__, | ||
| projectContext := __new__.projectContext, | ||
| container := __new__, | ||
| period := reportPeriod | ||
| }), | ||
| (insert default::NarrativeReport { | ||
| createdAt := datetime_of_statement(), | ||
| modifiedAt := datetime_of_statement(), | ||
| createdBy := assert_exists(global currentActor), | ||
| modifiedBy := assert_exists(global currentActor), | ||
| project := __new__, | ||
| projectContext := __new__.projectContext, | ||
| container := __new__, | ||
| period := reportPeriod | ||
| }) | ||
| )) | ||
| for reportPeriod in applicableReportPeriodsForDeletion | ||
| union ( | ||
| delete reportPeriod | ||
| ) | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| abstract type TranslationProject extending Project { | ||
|
|
@@ -259,4 +358,44 @@ module Project { | |
| )) | ||
| select reportPeriodRanges | ||
| ) | ||
|
|
||
| # TODO - Toying with the idea of abstracting some of this logic in some capacity... | ||
|
There was a problem hiding this comment. @CarsonF - After the trigger code settles down I think there's some opportunity for some common methods like I started here. There was a problem hiding this comment. I don't think functions can mutate data right now. I don't really understand the limitation. |
||
| # function insertReportPeriods(existingReportPeriods: set of range<cal::local_date>, | ||
| # requestedReportPeriods: set of range<cal::local_date>) -> optional str | ||
| # using ( | ||
| # with | ||
| # reportPeriodsWithoutFiles := ( | ||
| # select existingReportPeriods | ||
| # filter not exists .reportFile | ||
| # ), | ||
| # deletedReportPeriods : = ( | ||
| # for reportPeriod in reportPeriodsWithoutFiles | ||
| # union ( | ||
| # delete reportPeriod | ||
| # ) | ||
| # ) | ||
| # for reportPeriod in requestedReportPeriods | ||
| # union ( | ||
| # (insert default::FinancialReport { | ||
| # createdAt := datetime_of_statement(), | ||
| # modifiedAt := datetime_of_statement(), | ||
| # createdBy := assert_exists(global currentActor), | ||
| # modifiedBy := assert_exists(global currentActor), | ||
| # project := __new__, | ||
| # projectContext := __new__.projectContext, | ||
| # container := __new__, | ||
| # period := reportPeriod | ||
| # }), | ||
| # (insert default::NarrativeReport { | ||
| # createdAt := datetime_of_statement(), | ||
| # modifiedAt := datetime_of_statement(), | ||
| # createdBy := assert_exists(global currentActor), | ||
| # modifiedBy := assert_exists(global currentActor), | ||
| # project := __new__, | ||
| # projectContext := __new__.projectContext, | ||
| # container := __new__, | ||
| # period := reportPeriod | ||
| # }) | ||
| # ) | ||
| # ) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you want
?!=on these 3 comparisons. Since they are all optional fields. We want null on either side to count as a valid value to compare against, instead of skipping the comparison all together when null is encountered. It's a semi well known footgun that's complained about. Docs have notes on these ?-prefixed operators.