Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current report due prioritizing the final report #3293

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Sep 24, 2024

This was supposed to be fixed with #3200

Now the current report due is the most recently ending report (of the reports that have already ended) and of the reports with the same end date, the one that started first.

https://seed-company-squad.monday.com/boards/3451697530/pulses/7550491555

@CarsonF CarsonF requested a review from atGit2021 September 24, 2024 16:17
@CarsonF CarsonF force-pushed the bugfix/current-report-due-with-final-report branch from 9376481 to 8355b12 Compare September 24, 2024 17:13
@CarsonF CarsonF requested a review from atGit2021 September 24, 2024 17:14
Copy link
Contributor

@atGit2021 atGit2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CarsonF
Copy link
Member Author

CarsonF commented Sep 24, 2024

I'm realizing that we never have a cut off for this last report.
If the project ended in 2020, now we will still show the last real quarter report as the currently due report.
This doesn't seem right, but maybe should be addressed separately.
This can focus on the bug of showing the final report instead of the real last quarter report.

@CarsonF CarsonF merged commit 14999fc into develop Sep 24, 2024
15 checks passed
@CarsonF CarsonF deleted the bugfix/current-report-due-with-final-report branch September 24, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants