Fix delete auth check for posts delete #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume the post object is all that is needed to check permissions. This is because we know we want the creator to be able to delete. Previously other members could delete any post - this seems like a mistake. So this new code prevents that by not having the member context. This kinda breaks the isolation I wanted these to have from policies. I wanted policies to be in full control of the permissions. But we have to provide the right context/attributes. The project doesn't have the creator attribute (or even the right one). We could do a better job exposing exactly what attributes are given to the privileges service instead of the dto object wholesale. The policies are also ill-equipped to declare permissions for these "embedded" resources. A rewrite is needed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the post object is all that is needed to check permissions. This is because we know we want the creator to be able to delete.
Previously other members could delete any post - this seems like a mistake. So this new code prevents that by not having the member context.
This kinda breaks the isolation I wanted these to have from policies. I wanted policies to be in full control of the permissions.
But we have to provide the right context/attributes. The project doesn't have the creator attribute (or even the right one).
We could do a better job exposing exactly what attributes are given to the privileges service instead of the dto object wholesale.
The policies are also ill-equipped to declare permissions for these "embedded" resources.
A rewrite is needed there.