Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/basic asset reminders #1540

Merged
merged 97 commits into from
Jan 27, 2025
Merged

Feature/basic asset reminders #1540

merged 97 commits into from
Jan 27, 2025

Conversation

rockingrohit9639
Copy link
Contributor

Issue - #1472

@rockingrohit9639
feat(asset-reminder): create UI for asset reminders
bb9038d
@rockingrohit9639
feat(asset-reminders): create schema for asset reminder
19f8db6
@rockingrohit9639
feat(asset-reminders): create schema for asset reminder
1dbb296
@rockingrohit9639
feat(asset-reminder): create action to handle creating reminder
618894f
@rockingrohit9639
Merge branch 'feature/basic-asset-reminders' of github.com:rockingroh…
eb3b73a 
…it9639/shelf.nu into feature/basic-asset-reminders
@rockingrohit9639
cMerge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/bas…
68fc070 
…ic-asset-reminders
@rockingrohit9639
Merge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/basi…
2fbe8a7 
…c-asset-reminders
@rockingrohit9639
feat(asset-reminder): create page to display list of reminders
1e55fd2
@rockingrohit9639
feat(asset-reminders): create frontend for edit reminder
bedc2d0
@rockingrohit9639
feat(asset-reminder): create backend to edit reminder
d467b06
@rockingrohit9639
feat(asset-reminder): create feature to delete a reminder
89e7bab
@rockingrohit9639
Merge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/basi…
cf455ee 
…c-asset-reminders
@rockingrohit9639
feat(asset-reminders): add validation to select teamMember with user …
dbb2ec2 
…only
@rockingrohit9639
Merge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/basi…
629758e 
…c-asset-reminders
@rockingrohit9639 rockingrohit9639 self-assigned this Dec 20, 2024
@rockingrohit9639 rockingrohit9639 linked an issue Dec 20, 2024 that may be closed by this pull request
[Feature request]: Basic Asset Reminders #1472
Closed
@carlosvirreira
Copy link
Contributor

can this be tested soon? @DonKoko

DonKoko
DonKoko requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is an issue with the default sorting. It seems like its something with how the query is built with prisma based on the little research I did:
    image

app/modules/team-member/service.server.ts Outdated Show resolved Hide resolved
app/emails/logo.tsx Outdated Show resolved Hide resolved
app/emails/logo.tsx Show resolved Hide resolved
app/components/assets/asset-reminder-cards.tsx Show resolved Hide resolved
app/modules/asset-reminder/service.server.ts Show resolved Hide resolved
app/modules/asset-reminder/service.server.ts Show resolved Hide resolved
@carlosvirreira
Copy link
Contributor

  • I notice that if you create a new asset and start the 'create reminder' flow from the empty state CTA - that you get an error. This does not happen from the actions dropdown.

Screenshot 2025-01-22 at 12 19 11

  • If a reminder is sent but the user has been deleted. Then you can still click on the user profile and it will take you to a 'User not found' page.

Screenshot 2025-01-22 at 12 22 06

@carlosvirreira
Copy link
Contributor

@DonKoko @rockingrohit9639

I have not found any more things to give as feedback here.

Much respect. Good feature.

In my eyes. We can ship.

@DonKoko DonKoko merged commit 1d8dc0b into Shelf-nu:main Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko approved these changes

Assignees

@rockingrohit9639 rockingrohit9639

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Basic Asset Reminders
3 participants
@rockingrohit9639 @carlosvirreira @DonKoko