Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix asset image loader positioning issue #1631

Merged
merged 8 commits into from
Feb 7, 2025
Merged

fix asset image loader positioning issue #1631

merged 8 commits into from
Feb 7, 2025

Conversation

rockingrohit9639
Copy link
Contributor

Closes #1627

@rockingrohit9639 rockingrohit9639 self-assigned this Feb 6, 2025
DonKoko
DonKoko requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-07 at 10 34 23

Loading state is fixed but now normal images are broken.

Screenshot 2025-02-07 at 10 35 22

@DonKoko DonKoko merged commit e2afac7 into Shelf-nu:main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko approved these changes

Assignees

@rockingrohit9639 rockingrohit9639

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Wrong positioning of AssetImage loader
2 participants
@rockingrohit9639 @DonKoko