-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): Fields with default value are not set to advanced by default #9128
fix(platform): Fields with default value are not set to advanced by default #9128
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
We made a conscious choice to allow fields with default values that aren’t marked as advanced. There are times when we don’t want to automatically mark a field as advanced while still providing a default value. Does this updated version still allow inputs with default values that aren’t advanced? |
…ault-values-are-shown-as-non
Yes, This is the only reason I added this But #8739 makes all the values with default non-advanced unless it's explicitly defined to do so, which is not the expectation. |
…ault-values-are-shown-as-non
…ault-values-are-shown-as-non
#8739 causes input fields that are supposed to be an advanced field end up being a mandatory field:
*See the retry count field here.
Changes 🏗️
Set the
advanced
field on each input field, and set the default value using this logic:Checklist 📋
For code changes:
Example test plan
For configuration changes:
.env.example
is updated or already compatible with my changesdocker-compose.yml
is updated or already compatible with my changesExamples of configuration changes