Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Remove croniter #9130

Merged

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Dec 26, 2024

Croniter is unused, and it will be deprecated soon.

Changes πŸ—οΈ

Remove croniter.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested review from Swiftyos and kcze December 26, 2024 20:49
@majdyz majdyz requested a review from a team as a code owner December 26, 2024 20:49
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ No major issues detected

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Dec 26, 2024
Copy link

netlify bot commented Dec 26, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 8776445
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67740b6289bcbb0008cf42b4

Copy link

netlify bot commented Dec 26, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 8776445
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67740b6258544000081546bd

@majdyz majdyz enabled auto-merge December 26, 2024 20:51
@majdyz majdyz added this pull request to the merge queue Dec 31, 2024
Merged via the queue into dev with commit 10fc7d2 Dec 31, 2024
18 checks passed
@majdyz majdyz deleted the zamilmajdy/secrt-1029-croniter-deprecated-will-break-our-platform branch December 31, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants