Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix broken block UI layout #9132

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Dec 26, 2024

https://github.com/Significant-Gravitas/AutoGPT/pull/9097/files#diff-ef176e50a6a65af5df2182626ea868ce77b76de447c816fb4f80fb4d376c3049R7-R41 introduced styling changes to block UI layout which causes the block layout broken:

image

This PR minimally reverts the styling change.

Changes 🏗️

Minimal CSS revert to make the block UI layout back to normal.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner December 26, 2024 23:23
@majdyz majdyz requested review from ntindle, Pwuts, kcze and Abhi1992002 and removed request for a team December 26, 2024 23:23
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

CSS Specificity

The new CSS selector grouping may have different specificity than the original selectors. Verify that styles are still being applied with the expected precedence.

.custom-node [data-id="input-handles"],
.custom-node [data-id="input-handles"] > div > div {
  margin-bottom: 1rem;
}

.custom-node input:not([type="checkbox"]),
.custom-node textarea,
.custom-node select,
.custom-node [data-id^="date-picker"],
.custom-node [data-list-container],
.custom-node [data-add-item],
.custom-node [data-content-settings]
 {

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Dec 26, 2024
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit ee1a74c
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6772b8834a58160008a75125

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit ee1a74c
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6772b88324b0480008b176aa

ntindle
ntindle previously approved these changes Dec 26, 2024
@majdyz majdyz enabled auto-merge December 30, 2024 16:58
@majdyz majdyz added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@Swiftyos Swiftyos merged commit ea01c80 into dev Dec 31, 2024
20 checks passed
@Swiftyos Swiftyos deleted the zamilmajdy/open-2268-broken-block-ui-layout branch December 31, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 1 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants