Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chunks to use some types of custom QIODevice. #89

Closed
wants to merge 4 commits into from

Conversation

olya-r
Copy link

@olya-r olya-r commented Nov 27, 2017

I used QHexEdit with my own QIODevice that can't give all its data at once. On read it send a request for data and when it was received (asynchronously) the edit get updates. So I need some changes in Chunks.

Also I fixed typos that Visual Assist underlined. But I really do not know what 'contation' means.

@olya-r olya-r changed the title Olya - Let Chunks use some types of custom QIODevice. Fix Chunks to use some types of custom QIODevice. Nov 27, 2017
@Simsys
Copy link
Owner

Simsys commented Dec 12, 2018

Thank you for this pull request

I'm not sure if the extension "asynchronous reading" is interesting for other users. I have created a change request, see #103. If you are interested, please create a pull request, which only contains this function

I cleaned the typos, see e36d8ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants