Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ftp.vim to ftp.nluug #1563

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

idbrii
Copy link
Contributor

@idbrii idbrii commented Jan 8, 2025

Fix "curl: (6) Could not resolve host: ftp.vim.org" when running tests.

This is the link on https://www.vim.org/download.php#unix on this line:

There is one big file to download that contains almost everything. It
is found in the unix directory

Looks like that change happened years ago to use https instead of ftp: vim/vim#3580

Test

Ran this script under Ubuntu on WSL:

VIM_VERSION=8.1
curl https://ftp.nluug.nl/pub/vim/unix/vim-${VIM_VERSION}.tar.bz2 -o vim.tar.bz2
tar xjf vim.tar.bz2
mv -v vim?? vim
ls vim/src/ | wc -l # outputs 255

I'm not certain it's the correct package, but it has source which seems comparable to cloning from git.

Fix "curl: (6) Could not resolve host: ftp.vim.org" when running tests.

This is the link on https://www.vim.org/download.php#unix on this line:
> There is one big file to download that contains almost everything. It
> is found in the unix directory

Looks like that change happened years ago to use https instead of ftp:
vim/vim#3580
@idbrii
Copy link
Contributor Author

idbrii commented Jan 8, 2025

Some tests finally pass!

This test seems to be the one that fails, but only on older vim versions. Maybe vim 9 fixed something? Regardless, that's unrelated to this change.

[2025-01-08 05:56:52] FAIL: runTest (test_Plugin.Plugin_SuperTab_SimpleTest)
[2025-01-08 05:56:52] ----------------------------------------------------------------------
[2025-01-08 05:56:52] Traceback (most recent call last):
[2025-01-08 05:56:52]   File "/src/UltiSnips/test/vim_test_case.py", line 61, in runTest
[2025-01-08 05:56:52]     self.assertMultiLineEqual(self.output, wanted)
[2025-01-08 05:56:52] AssertionError: ' ---[34 chars]longtext\nlongt\t\nHello\n\n --- some text after --- ' != ' ---[34 chars]longtext\nlongtextlongtext\nHello\n\n --- some text after --- '
[2025-01-08 05:56:52]    --- some text before --- 
[2025-01-08 05:56:52]   
[2025-01-08 05:56:52]   longtextlongtext
[2025-01-08 05:56:52] - longt	
[2025-01-08 05:56:52] + longtextlongtext
[2025-01-08 05:56:52]   Hello
[2025-01-08 05:56:52]   
[2025-01-08 05:56:52]    --- some text after --- 
[2025-01-08 05:56:52] 
[2025-01-08 05:56:52] ----------------------------------------------------------------------
[2025-01-08 05:56:52] Ran 147 tests in 47.365s
[2025-01-08 05:56:52] 
[2025-01-08 05:56:52] FAILED (failures=1)

@SirVer
Copy link
Owner

SirVer commented Jan 11, 2025

Thank you, while not fixing everything, this is clearly a big improvement. ❤️

@SirVer SirVer merged commit 35252b3 into SirVer:master Jan 11, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants