Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relative paths with absolute #111

Closed
wants to merge 5 commits into from

Conversation

vtrifonov
Copy link

Related to #65
When relative paths are used as in angular .d.ts files those relative paths to be changed to absolute when merging the .d.ts files.

Copy link
Contributor

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems reasonable enough, but I think we need to add a test for it (even though I realize the current test setup is failing, we should still add a test so we remember what this change is fixing. :)

stack.pop(); // remove current file name (or empty string)
// (omit if "base" is the current folder without trailing slash)
for (var i = 0; i < parts.length; i++) {
if (parts[i] == ".")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if and else clauses here don't follow the code style guidelines here.

@vtrifonov vtrifonov closed this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants