Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow name node kind to be Identifier #126

Closed
wants to merge 1 commit into from
Closed

fix: allow name node kind to be Identifier #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ function isNodeKindStringLiteral(value: ts.Node): value is ts.StringLiteral {
return value && value.kind === ts.SyntaxKind.StringLiteral;
}

function isNodeKindIdentifier(value: ts.Node): value is ts.Identifier {
return value && value.kind === ts.SyntaxKind.Identifier;
}

function isNodeKindExportDeclaration(value: ts.Node): value is ts.ExportDeclaration {
return value && value.kind === ts.SyntaxKind.ExportDeclaration;
}
Expand Down Expand Up @@ -327,7 +331,7 @@ export default function generate(options: Options): Promise<void> {
processTree(sourceFile, function (node) {
if (isNodeKindModuleDeclaration(node)) {
const name = node.name;
if (isNodeKindStringLiteral(name)) {
if (isNodeKindStringLiteral(name) || isNodeKindIdentifier(name)) {
declaredExternalModules.push(name.text);
}
}
Expand Down