Add tests for effects #6204
Add tests for effects #6204
Conversation
| @@ -40,7 +40,7 @@ dependencies { | |||
| implementation fileTree(dir: 'lib', include: '*.jar') | |||
|
|
|||
| testShadow group: 'junit', name: 'junit', version: '4.13.2' | |||
| testShadow group: 'org.easymock', name: 'easymock', version: '5.2.0' | |||
| testShadow group: 'org.easymock', name: 'easymock', version: '5.0.1' | |||
There was a problem hiding this comment.
it seems like 5.2.0 has a bug. on v5.0.1, the action bar test passes. however, when running this exact same code in v5.2.0, the action bar test encounters the exception described in easymock/easymock#356. that issue was apparently fixed in 5.2.0 but i wonder if it wasn't a complete fix. it could definitely be user error too though. i will probably followup on that issue and see what the maintainers think.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't think I know enough about EasyMock to comment on that code with authority, but everything looks alright from a glance. This seems like a very useful tool for player-related testing!
I may come back and actually approve once I know a bit more about how easymock works.
sovdeeth
added
the
enhancement
Pikachu920
force-pushed
the
feature/effect-tests-1
branch
from
0692fc4 to
c1ab9c4
Compare
it's really pretty simple! i don't know how it's actually implemented, but it's basically like a proxy that keeps track of it's method calls. You use |
…to feature/effect-tests-1
sovdeeth
added
the
feature-ready
We cannot use EasyMock on Java 21 as we must stay on an older version (see #6204 (comment)) Java 21 will be supported for regular testing. A 1.20.4 environment remains for Java 17
* Internal support for aliases item components * Update aliases submodule It now targets to the 1.20.5 support branch * Update isRunningMethod check * Add ability to opt out of deduplication This is useful for items that have NBT that is not represented by an ItemMeta implementation (e.g. block entity data) * Update skript-aliases * Update skript-aliases * Update skript-aliases * Update Gradle to 8.7 * Update Paper to 1.20.6 Also updates Java from 17 to 21 * Fix latest env for testing * Fix AreaEffectCloudApplyEvent event value * Fix vehicle dismount events * Fix potions * Get visual effects building Removed ones do not currently work on new versions... * Fix unused AbstractList implementation * Fix remaining Java 17 references * Fix 1.17 testing * Add missing PotionDataUtils check * Add missing lang entries * Rework Test Environments We cannot use EasyMock on Java 21 as we must stay on an older version (see #6204 (comment)) Java 21 will be supported for regular testing. A 1.20.4 environment remains for Java 17 * Update workflow names --------- Co-authored-by: Moderocky <[email protected]>
|
Please try with EasyMock 5.4.0-SNAPSHOT. It should be fixed. |
Description
This is a PR to add tests for as many effects as I can.
Target Minecraft Versions: any
Requirements: N/A
Related Issues: #6158