feat(action): ajoute modification action #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo-theg
force-pushed
the
feat/ajoute-modification-action
branch
5 times, most recently
from
ef2ce11 to
ef619a2
Compare
oni-Sk
suggested changes
Dec 27, 2023
src/domain/action/action.ts
Outdated
| const contenu = infosActionAMettreAJour.contenu ?? action.contenu | ||
| const description = | ||
| infosActionAMettreAJour.description ?? action.description | ||
| const dateFinReelle = this.mettreAJourLaDateDeFinReelle( |
There was a problem hiding this comment.
La méthode vient pas de toi, mais en regardant son code je questionne la lisibilité de son implémentation. On comprend pas trop la règle métier en la lisant je pense qu'elle peut être simplifiée
src/application/commands/action/update-action.command.handler.ts
Outdated
Show resolved
Hide resolved
test/application/commands/action/update-action.command.handler.test.ts
Outdated
Show resolved
Hide resolved
|
PS : Sonar bug, il met 4 new issues c'est pour 4 tests unitaires il détecte pas les expect je sais pas pourquoi. On peut ignorer je pense |
|
PS 2 : le nom du commit "ajoute modification" -> "modifie une action" |
oni-Sk
approved these changes
Dec 28, 2023
octo-theg
force-pushed
the
feat/ajoute-modification-action
branch
from
4c8bf69 to
eaf5564
Compare
|
Mzem
pushed a commit
that referenced
this pull request
Jan 4, 2024
Mzem
pushed a commit
that referenced
this pull request
Jan 4, 2024
Mzem
pushed a commit
that referenced
this pull request
Jan 4, 2024
Mzem
pushed a commit
that referenced
this pull request
Jan 5, 2024
Mzem
pushed a commit
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.