Add nodeNoWarningsFlags constant

SocketDev · Dec 13, 2024 · 2301a2e · 2301a2e
1 parent 49d24d4
commit 2301a2e
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/registry/lib/constants.d.ts b/registry/lib/constants.d.ts
@@ -140,6 +140,9 @@ declare const constantsModule: {
   readonly kInternalsSymbol: typeof kInternalsSymbol
   readonly lifecycleScriptNames: ReadonlySet<string>
   readonly maintainedNodeVersions: MaintainedNodeVersions
+  readonly nodeNoWarningsFlags:
+    | ReadonlyArray<['--disable-warning', 'ExperimentalWarning']>
+    | ReadonlyArray<['--no-warnings']>
   readonly npmExecPath: string
   readonly packageExtensions: ReadonlyArray<[string, object]>
   readonly packumentCache: Map<unknown, unknown>

diff --git a/registry/lib/constants.js b/registry/lib/constants.js
@@ -325,6 +325,13 @@ const lazyMaintainedNodeVersions = () => {
   )
 }
 
+const lazyNodeNoWarningsFlags = () =>
+  Object.freeze(
+    constants.SUPPORTS_NODE_DISABLE_WARNING_FLAG
+      ? ['--disable-warning', 'ExperimentalWarning']
+      : ['--no-warnings']
+  )
+
 const lazyNpmExecPath = () => whichSync('npm')
 
 const copyLeftLicenses = new Set([
@@ -573,6 +580,7 @@ const constants = createConstantsObject(
     ignoreGlobs,
     lifecycleScriptNames,
     maintainedNodeVersions: undefined,
+    nodeNoWarningsFlags: undefined,
     npmExecPath: undefined,
     packageExtensions,
     packumentCache,
@@ -591,6 +599,7 @@ const constants = createConstantsObject(
       SUPPORTS_NODE_REQUIRE_MODULE: LAZY_SUPPORTS_NODE_REQUIRE_MODULE,
       SUPPORTS_NODE_RUN: LAZY_SUPPORTS_NODE_RUN,
       maintainedNodeVersions: lazyMaintainedNodeVersions,
+      nodeNoWarningsFlags: lazyNodeNoWarningsFlags,
       npmExecPath: lazyNpmExecPath
     }
   }

diff --git a/registry/lib/npm.js b/registry/lib/npm.js
@@ -24,10 +24,11 @@ async function runBin(binPath, args, options) {
     [
       ...(WIN_32
         ? []
-        : // Lazily access constants.SUPPORTS_NODE_DISABLE_WARNING_FLAG.
-          constants.SUPPORTS_NODE_DISABLE_WARNING_FLAG
-          ? ['--disable-warning', 'ExperimentalWarning', binPath]
-          : ['--no-warnings', binPath]),
+        : [
+            // Lazily access constants.nodeNoWarningsFlags.
+            ...constants.nodeNoWarningsFlags,
+            binPath
+          ]),
       ...args
     ],
     {
@@ -47,9 +48,11 @@ async function runScript(scriptName, args, options) {
     cmd,
     [
       ...(useNodeRun
-        ? constants.SUPPORTS_NODE_DISABLE_WARNING_FLAG
-          ? ['--disable-warning', 'ExperimentalWarning', '--run']
-          : ['--no-warnings', '--run']
+        ? [
+            // Lazily access constants.nodeNoWarningsFlags.
+            ...constants.nodeNoWarningsFlags,
+            '--run'
+          ]
         : ['run']),
       scriptName,
       ...args