Prevented recovery middleware from printing stack #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
AleF83
approved these changes
May 15, 2018
| @@ -70,7 +70,9 @@ func newApp(config *appConfig.Configuration) http.Handler { | |||
| authenticationMiddleware := security.AuthenticationMiddleware(&config.Security, auditor) | |||
| authorizationMiddleware := security.AuthorizationMiddleware(enforcer, auditor) | |||
|
|
|||
| middleware := negroni.New(negroni.NewRecovery()) | |||
| recovery := negroni.NewRecovery() | |||
| recovery.PrintStack = false | |||
There was a problem hiding this comment.
There is an open issue about this
urfave/negroni#214
So I think it will be redundant.
Good for now.
michaelkruglos
added a commit
that referenced
this pull request
Dec 20, 2018
* WIP building request transformation * WIP * Working /api/v2/values endpoint * WIP: added initial implementation of authorization enforcement * Improved tests * small refactor and implementation of model reading and writing * Implemented tags middleware and refactored routing * v1 conttoller adde * fix * host fixed * Adding secure-gateway to CI * isAlive added * modelManagement package added * add security to modelMangement handler * exception handled * context transform added * schemas added to transformation * goThrough host to config * CI: still work in progress, need to account for v1 routes, that don't start with api/v1 * Added health endpoint * refactor * Fixed integration tests and smoke tests * tiny refactor * extract from request added * added act mapping * tests added to extract * Codefresh almost works * jwt token added * jwtUtils moved package * Fixed models test * Added support for groups using casbin * Fixed and improved tests * WIP implementing git policy repository * CI fixes for policyRepositories * Fixes for CI * add mutex to jwt token creation * bug fixed in gateway * Healthcheck added to secure-gateway dockerfile (#726) Healthcheck added to secure-gateway dockerfile * 730 gateway accepts tweekinternals (#731) Add support for tweekinternal authentication to gateway * 734 move auth midware to routes (#735) Auth middleware moved from app level to route level #734 * go fmt added to linters (#733) * Go fmt linter bug fixed (#739) * No fixed... * 700 audit log (#732) * WIP audit * Implementing audit, stabilizing e2e * Adding audit interface and implementation * Returend sudo to run_tests.sh * Some fixes for review * Fixes for review * 737 store gateway rules in minio (#741) store gateway rules in minio instead of git * Config package changed (#746) App Config package changed from viper to configor * E2E added to gateway (#750) E2E added to gateway * Separate OpenIdConnect and Tweek Issuer jwt validation (#760) * Casbin policy refresh added (#759) * CORS support added to secure-gateway (#743) CORS support added to secure-gateway * Merge master to secure-gateway (#772) * 740 Publishing service pushes policy to minio (#765) * 738 policies (#762) * Fixed typo in comments * Changes in ExtractFromRequest to account for contexts * Added more tests and fixed bugs * Small fixes * Implementing matchResource function WIP * WIP * Some review fixes * Added regexp support and more tests WIP * Refactored code and fixed tests * Small fix * Fixed CI files * Switched from regexp to wildcard * Fixed policy.csv * Refactored: changed regexp to wildcard * Refactored map into struct * Added resource deffinition documentation * Fixes for tests * fixes for CI and tests * Fixes * 775 authorize tweek issuer by issuer w/o email check (#777) * Editor as SPA (#792) * Prevented recovery middleware from printing stack (#821) * Implemented JWK cache (#818) * Implemented JWK cache * Adjusting authorization to work as designed (#823) * Adjusting authorization to work as designed * Fix for tests * Fixed policies * Fixes for review * Fixes to simplify authorization model * Fixes for previous commit * More fixes * Updated resource deffinition document * Removed unnecessary line from policy.csv * Fixes for policy.csv * Fixes for request utils * Fixes for review * e2e integration tests for api v2 (#827) * Added tests covering v2 API * Created k8s yaml for gateway (#831) * Created k8s yaml for gateway * Fixes * Fixes for review * Renamed secure-gateway as gateway (#836) * Added pod disruption budget * Added metrics per upstream for passthrough (#840) * Added metrics per upstream for passthrough * Fixes for review * fix after merge * remove deleted files added by merge * make restore command added to gateway makefile * fix card_view after merge from master * Add editor local configuration (#853) * Allow credentials should be always true (#857) * implemented extraction of user info with opa/rego (#859) * implemented extraction of user info with opa/rego * Fix for CI * Fixes for review * Fixes for review * Renamed UserAndGroupExtractor to SubjectExtractor * Small fixes * Set editor backend url properly (#856) * Remove envVars.js * get env var from window object as fallback * PR CR changes * 846 Controller for gateway that returns status of all services (#860) * 862 - Publishing validates sub extraction rules while sync to minio (#864) * e2e editor backend url fixed * Replaced casbin with OPA (#871) * Replaced casbin with OPA * Uncommented test cases * Refactored subject treatment * Fixed requestUtils * Small naming fix * Added opa tests and fixed sub in Authorize * Added test files * Fix for docker * Made local config files not configurable (#874) * Adapted policies endpoint in authoring for use with OPA (#880) * Added rules extraction endpoint (#881) * Added rules extraction endpoint * Removed unnecessary console.log * Naming fix * Added policy validation to publishing (#882) * Policies PATCH method added to authoring (#896) * Gateway config moved to mounted volume (#855) * Gateway config moved to mounted volume * logger changed from gateway * volumes instruction fixed * small fix * . * .. * .... * Fix for Dockerfile * Revert "...." This reverts commit 520e6af. * Revert ".." This reverts commit 364e1b8. * Revert "." This reverts commit 4e7d4c3. * Fixes for CI * Fixes for CI * Fixes for CI * Fixes for CI * Fixes for CI * Fixed merge * Fixes for CI * Fixes for merge * Fixes for merge * Pushing gateway images * Small fix * Added push step for git repository * Swagger for gateway & some more security and policy changes (#899) * Fixed regression in password verification for basic auth * Revert "Fixed regression in password verification for basic auth" This reverts commit 7a7f86d. * Fixed key derivation in publishing * Fixed git repository * Implemented anonymous access (#921) * Added percentile 75 and 95 to gateway (#933) * Added percentile 75 and 95 to gateway * Fix for review * Support for serving editor through gateway (#923) * Added build id tags to gateway builds * Implemented wildcard context (#938) * Implemented Azure login (#948) * Implemented Azure login * Fixed missing configuration * Changed auth code to use id_token * Removed redundant console.log * Fixes for review * Fixed a small bug * Bug fixes for login * Added token expiration check in isAuthenticated (#952) * Impelmented userinfo endpoint (#959) * Impelmented userinfo endpoint * Added http error status * Moved the endpoint to /api/v2 * Renamed the endpoint to current-user to reflect the semantics * Added /configurations endpoint (#963) * Added /configurations endpoint * Changed how /configurations/ path is mounted * Refactored passThrough (#967) * Moved security related files to security folder in repo (#969) * Moved security related files to security folder in repo * Fixed authoring * Reverted CONFIGOR_ENV in docker-compose files * Added editor context to requests for configuration (#970) * Added editor context to requests for configuration * Fixed configuration key name * Fixed getConfiguration * Fixed policy.json * Fixed status endpoint (#971) * Fixed status endpoint * Fixes for review * Fixed name and email extraction in gateway (#974) * Fixed name and email extraction in gateway * Fixes for review * Small fixes * Removed anonymous from name and email (#975) * Fixed stale revision checking (#978) * Implemented keyPath transformation (#979) * Implemented keyPath transformation * Review fixes * Fixes for review * Fixed settings.json * Added repo revision to status (#982) * Added repo revision to status * Fixes for previous commit * Fixed test * Fixed /api/v1 with no host case (#985) * Fixed swagger.yml (#988) * Fixed swagger.yml * Implemented serving swagger.yml file * Added swagger.go * Fixed StaleRevisionException being thrown when there is another problem (#1013) * Added metrics to publishing (#1015) * Fixed silent token refresh issue (#1020) * Fixed stale revision issue (#1023) * Refreshing JWKs when key is missing (#1022) * Refresh if key is missing * Fixed read for context in gateway (#1025) * Fixed login expiration (#1029) * Fixed login expiration * Fixed redirect after login (#1031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #820