S48 1126 r d automation of webhook triggered http functions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e webhook creation payloads, which are written to a file in .build
…ith every cloudseed build, for handling all BC webhooks
… renamed said publisher function
…de and pipelines file
…ions' of bitbucket.org:joeward/cloud-seed-testing into S48-1126-r-d-automation-of-webhook-triggered-http-functions
Current limitations: doesn't reliably handle hooks in form |
ansnaldo
reviewed
Oct 19, 2022
| export type WebhookConfig = { | ||
| type: "webhook"; | ||
| webhook: { | ||
| type: "bigcommerce"; |
There was a problem hiding this comment.
It could be extended to other webhook types in future. But for now its only bigcommerce
ansnaldo
approved these changes
Oct 19, 2022
| }; | ||
|
|
||
| export function getPubSubTopicName(scope: string, type: string): string { | ||
| return `webhook-${type}-${scope.split("/").join("-")}`; |
There was a problem hiding this comment.
this could be getWebhookPubSubTopicName() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.