Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support restoring from a cluster snapshot for shared-data mode (part 4, use gtid to handle dirty tablet metadata) #54484

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[Feature] Support restoring from a cluster snapshot for shared-data mode (part 4, use gtid to handle dirty tablet metadata) #54484

merged 1 commit into from
Jan 2, 2025
+86 −91

Conversation

xiangguangyxg
Copy link
Contributor

Why I'm doing:

The dirty data must be handled after restoring from a cluster snapshot.

What I'm doing:

Use gtid to handle dirty tablet metadata in publish version.

Fixes #53867

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@xiangguangyxg xiangguangyxg requested a review from a team as a code owner December 30, 2024 04:15
@xiangguangyxg xiangguangyxg force-pushed the algin_data_with_metadata branch 2 times, most recently from 16e2165 to 507986b Compare December 30, 2024 06:16
kevincai
kevincai previously approved these changes Dec 30, 2024
View reviewed changes
@xiangguangyxg xiangguangyxg force-pushed the algin_data_with_metadata branch from 507986b to 5ad16fe Compare December 30, 2024 09:35
@xiangguangyxg
[Feature] Support restoring from a cluster snapshot for shared-data m…
1a590b0 
…ode (part 4, use gtid to handle dirty tablet metadata)

Signed-off-by: xiangguangyxg <[email protected]>
@xiangguangyxg xiangguangyxg force-pushed the algin_data_with_metadata branch from 5ad16fe to 1a590b0 Compare January 1, 2025 14:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

[BE Incremental Coverage Report]

❌ fail : 26 / 50 (52.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/tablet_manager.cpp 13 30 43.33% [140, 141, 142, 143, 257, 258, 263, 265, 267, 274, 275, 276, 277, 278, 280, 281, 282]
🔵 be/src/storage/lake/transactions.cpp 5 10 50.00% [96, 97, 208, 275, 276]
🔵 be/src/storage/lake/metadata_iterator.cpp 4 6 66.67% [29, 39]
🔵 be/src/storage/lake/update_manager.cpp 1 1 100.00% []
🔵 be/src/storage/lake/lake_delvec_loader.cpp 2 2 100.00% []
🔵 be/src/storage/lake/metadata_iterator.h 1 1 100.00% []

@wyb wyb enabled auto-merge (squash) January 2, 2025 11:39
@andyziye andyziye disabled auto-merge January 2, 2025 11:42
@andyziye andyziye merged commit e7b9653 into StarRocks:main Jan 2, 2025
46 of 47 checks passed
@wanpengfei-git wanpengfei-git mentioned this pull request Jan 2, 2025
Closed
5 tasks
@xiangguangyxg xiangguangyxg deleted the algin_data_with_metadata branch January 2, 2025 11:43
@xiangguangyxg
Copy link
Contributor Author

@mergify backport branch-3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 2, 2025
@xiangguangyxg @mergify
[Feature] Support restoring from a cluster snapshot for shared-data m…
e7e4a65 
…ode (part 4, use gtid to handle dirty tablet metadata) (#54484)

Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit e7b9653)

# Conflicts:
#	format-sdk/src/main/cpp/format/starrocks_format_writer.cpp
@mergify mergify bot mentioned this pull request Jan 2, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 2, 2025
@mergify @xiangguangyxg
[Feature] Support restoring from a cluster snapshot for shared-data m…
ab6456f 
…ode (part 4, use gtid to handle dirty tablet metadata) (backport #54484) (#54598)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.4-merged version:3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shared-data mode support backup restore though automated snapshot
4 participants
@xiangguangyxg @kevincai @wyb @andyziye