Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix corrupted partition meta exception when refreshing materialized views… #54487

Merged

Conversation

kobebryantlin0
Copy link
Contributor

@kobebryantlin0 kobebryantlin0 commented Dec 30, 2024

fix the unexpected errors when refreshing materialized views using JDBC Catalog

Why I'm doing:

see more #54486

What I'm doing:

Fixes #54486

What type of PR is this:

  • BugFix

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.4
  • 3.3
  • 3.2
  • 3.1
  • 3.0

@kobebryantlin0 kobebryantlin0 requested a review from a team as a code owner December 30, 2024 06:14
@kobebryantlin0 kobebryantlin0 force-pushed the fix-meta-refresh-failure branch from 77dfccb to a9a6f21 Compare December 30, 2024 07:44
@kobebryantlin0 kobebryantlin0 changed the title [BugFix] fix the unexpected errors when refreshing materialized views… [BugFix] fix corrupted partition meta exception when refreshing materialized views… Dec 30, 2024
@kobebryantlin0 kobebryantlin0 force-pushed the fix-meta-refresh-failure branch from a9a6f21 to ad01594 Compare December 30, 2024 12:59
Copy link

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/jdbc/MysqlSchemaResolver.java 5 5 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@LiShuMing
Copy link
Contributor

This is just a walk-aroud, since it will be triggered to be refreshed for each refresh because we can not deduce the partition's real refresh time.

Copy link
Contributor

@LiShuMing LiShuMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stephen-shelby stephen-shelby merged commit 9478087 into StarRocks:main Dec 31, 2024
52 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 31, 2024
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 31, 2024
…erialized views… (#54487)

Signed-off-by: AlgoLin <[email protected]>
(cherry picked from commit 9478087)
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
…erialized views… (#54487)

Signed-off-by: AlgoLin <[email protected]>
(cherry picked from commit 9478087)
@kobebryantlin0
Copy link
Contributor Author

This is just a walk-aroud, since it will be triggered to be refreshed for each refresh because we can not deduce the partition's real refresh time.

yes, when we cannot get any partition statistics from the external catalog, it may be easier for users to accept this way. I see that SR uses the same method when querying paimon or PostgreSQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Throw unexpected errors when refreshing materialized views using JDBC Catalog
4 participants