Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix primary key table add an visible rowset #54491

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Dec 30, 2024

Why I'm doing:

Primary key table keep its own visible rowsets in TabletUpdatesPB, so primary key table should not call Tablet::add_rowset function [1].
However, when we update schema version, we will first get all COMMITTED rowsets and rewrite these rowsets meta[2]. But this could run concurrency with publish version task and these rowsets will be update to VISIBLE[3]. So we will write a visible rowset into RocksDB for primary key table.

What I'm doing:

  1. Check rowset state before rewrite rowset meta into RocksDB.
  2. Skip visible RowsetMetaPB in RocksDB if table is a primary key table and the RowsetMetaPB will be deleted when the rowset is expired.

Fixes https://github.com/StarRocks/StarRocksTest/issues/9002

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@sevev sevev requested a review from a team as a code owner December 30, 2024 07:10
@mergify mergify bot assigned sevev Dec 30, 2024
Signed-off-by: sevev <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 6 / 19 (31.58%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/data_dir.cpp 0 13 00.00% [418, 419, 420, 422, 423, 424, 425, 427, 428, 429, 430, 431, 432]
🔵 be/src/storage/tablet_meta.cpp 3 3 100.00% []
🔵 be/src/storage/tablet.cpp 3 3 100.00% []

@sevev
Copy link
Contributor Author

sevev commented Dec 31, 2024

@mergify backport branch-3.3.8

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.3.8

✅ Backports have been created

@andyziye andyziye merged commit 15aea9e into StarRocks:main Dec 31, 2024
46 of 47 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 31, 2024
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 31, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 31, 2024
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants