-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix primary key table add an visible rowset #54491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 6 / 19 (31.58%) file detail
|
wyb
approved these changes
Dec 31, 2024
decster
approved these changes
Dec 31, 2024
@mergify backport branch-3.3.8 |
✅ Backports have been created
|
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 15aea9e)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 15aea9e)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 15aea9e)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 15aea9e)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 31, 2024
#54529) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 31, 2024
#54526) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 31, 2024
#54528) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 31, 2024
#54527) Co-authored-by: zhangqiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Primary key table keep its own visible rowsets in
TabletUpdatesPB
, so primary key table should not callTablet::add_rowset
function [1].However, when we update schema version, we will first get all
COMMITTED
rowsets and rewrite these rowsets meta[2]. But this could run concurrency with publish version task and these rowsets will be update toVISIBLE
[3]. So we will write a visible rowset into RocksDB for primary key table.What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/9002
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: