Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add timeout configs for star client #54496

Merged
merged 1 commit into from
Dec 31, 2024
Merged

[Enhancement] add timeout configs for star client #54496

merged 1 commit into from
Dec 31, 2024
+21 −1

Conversation

starrocks-xupeng
Copy link
Contributor

Why I'm doing:

What I'm doing:

  1. add star_client_read_timeout_seconds
  2. add star_client_list_timeout_seconds
  3. add star_client_write_timeout_seconds

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

kevincai
kevincai previously approved these changes Dec 30, 2024
View reviewed changes
wyb
wyb previously approved these changes Dec 30, 2024
View reviewed changes
@wyb wyb enabled auto-merge (squash) December 30, 2024 11:37
auto-merge was automatically disabled December 31, 2024 02:17

Head branch was pushed to by a user without write access

@starrocks-xupeng starrocks-xupeng dismissed stale reviews from wyb and kevincai via 9547017 December 31, 2024 02:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 11 / 11 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Config.java 3 3 100.00% []
🔵 com/starrocks/lake/StarOSAgent.java 8 8 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kevincai kevincai merged commit e0465c9 into StarRocks:main Dec 31, 2024
66 of 67 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 31, 2024
@starrocks-xupeng @mergify
[Enhancement] add timeout configs for star client (#54496)
75f78e9 
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit e0465c9)
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
@starrocks-xupeng @mergify
[Enhancement] add timeout configs for star client (#54496)
27388b1 
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit e0465c9)
This was referenced Dec 31, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
@starrocks-xupeng @mergify
[Enhancement] add timeout configs for star client (#54496)
f051eac 
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit e0465c9)
@mergify mergify bot mentioned this pull request Dec 31, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024
@mergify @starrocks-xupeng
[Enhancement] add timeout configs for star client (backport #54496) (#…
b0eb44b 
…54545)

Co-authored-by: starrocks-xupeng <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024
@mergify @starrocks-xupeng
[Enhancement] add timeout configs for star client (backport #54496) (#…
e37c993 
…54546)

Co-authored-by: starrocks-xupeng <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024
@mergify @starrocks-xupeng
[Enhancement] add timeout configs for star client (backport #54496) (#…
fa23520 
…54547)

Co-authored-by: starrocks-xupeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb left review comments

Assignees

@starrocks-xupeng starrocks-xupeng

Labels
3.2-merged 3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starrocks-xupeng @kevincai @wyb @murphyatwork