forked from SKCraft/Launcher
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Launcher #1
Open
Bysokar
wants to merge
52
commits into
StargateMC:master
Choose a base branch
from
SKCraft:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minecraft's default logging configs output XML to stdout, because the modern launcher parses it to provide a "nicer" console. We don't do that, so this commit adds embedded versions of the logging configs which just output log lines normally.
If the user cancelled the install process after the temp logging config file was created, but before the installer executes, the pack would fail to install on relaunch. Fix by allowing overwriting of the temp file.
"mandatory migration" my ass
Found some more edge cases in the wild - though to be honest this entire thing is edge cases. Sometimes /release exists, but the actual binaries are in /jre/bin; this commit changes behaviour to look for the two things independently.
Jackson upgrade exposed/introduced a bug where the JVM half of Minecraft arguments could end up missing in some cases. Not exactly sure if the field was null on the serializing side or just an empty array, but we just fix it by always initializing the fields.
The meaning of `mapper.setSerializationInclusion` changed with the Jackson upgrade, which meant that empty collections were being fully stripped from the output. Fix by changing the strategy to NON_ABSENT, which only strips nulls and "absent" values like Optional.absent
It's pretty likely that we would always read 3 bytes but let's do it properly
... with a caveat that it may break in future due to Quilt's broken metadata
Fixes resource downloads
this emulates the behavior of the vanilla launcher. it's important because if the vanilla jar is first, Log4j will always auto-detect the vanilla log4j.xml instead of Forge's.
tries old dotfolder first
Fix for forge 1.20.4; the generated client jar is specified as a library because it goes on the classpath now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.