Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Launcher #1

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Updating Launcher #1

wants to merge 52 commits into from

Conversation

Bysokar
Copy link

@Bysokar Bysokar commented Jun 18, 2023

No description provided.

hedgehog1029 and others added 30 commits December 31, 2021 21:12
Minecraft's default logging configs output XML to stdout, because the
modern launcher parses it to provide a "nicer" console. We don't do
that, so this commit adds embedded versions of the logging configs which
just output log lines normally.
If the user cancelled the install process after the temp logging config
file was created, but before the installer executes, the pack would fail
to install on relaunch. Fix by allowing overwriting of the temp file.
Found some more edge cases in the wild - though to be honest this entire
thing is edge cases. Sometimes /release exists, but the actual binaries
are in /jre/bin; this commit changes behaviour to look for the two
things independently.
Jackson upgrade exposed/introduced a bug where the JVM half of Minecraft
arguments could end up missing in some cases. Not exactly sure if the
field was null on the serializing side or just an empty array, but we
just fix it by always initializing the fields.
The meaning of `mapper.setSerializationInclusion` changed with the
Jackson upgrade, which meant that empty collections were being fully
stripped from the output. Fix by changing the strategy to NON_ABSENT,
which only strips nulls and "absent" values like Optional.absent
It's pretty likely that we would always read 3 bytes but let's do it
properly
... with a caveat that it may break in future due to Quilt's broken
metadata
hedgehog1029 and others added 22 commits January 17, 2023 11:03
Fixes resource downloads
this emulates the behavior of the vanilla launcher. it's important because if the vanilla jar is first, Log4j will always auto-detect the vanilla log4j.xml instead of Forge's.
tries old dotfolder first
Fix for forge 1.20.4; the generated client jar is specified as a library
because it goes on the classpath now.
We now parse out library names in order to compare them by group, path
and classifier instead of comparing the whole string.
Fixes #530 and #533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants